Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Deleted LayoutDelegate and HarmonyLayoutDelegate. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h" 5 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h" 12 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h"
13 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h" 13 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h"
14 #include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
14 #include "chrome/grit/generated_resources.h" 15 #include "chrome/grit/generated_resources.h"
15 #include "components/grit/components_scaled_resources.h" 16 #include "components/grit/components_scaled_resources.h"
16 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
17 #include "ui/base/resource/resource_bundle.h" 18 #include "ui/base/resource/resource_bundle.h"
18 #include "ui/events/event_utils.h" 19 #include "ui/events/event_utils.h"
19 #include "ui/events/test/event_generator.h" 20 #include "ui/events/test/event_generator.h"
20 #include "ui/gfx/color_palette.h" 21 #include "ui/gfx/color_palette.h"
21 #include "ui/gfx/image/image.h" 22 #include "ui/gfx/image/image.h"
22 #include "ui/gfx/image/image_unittest_util.h" 23 #include "ui/gfx/image/image_unittest_util.h"
23 #include "ui/gfx/paint_vector_icon.h" 24 #include "ui/gfx/paint_vector_icon.h"
(...skipping 13 matching lines...) Expand all
37 public: 38 public:
38 views::View* TestCreateExtraView() { 39 views::View* TestCreateExtraView() {
39 DCHECK(bubble_); 40 DCHECK(bubble_);
40 return bubble_->CreateExtraView(); 41 return bubble_->CreateExtraView();
41 } 42 }
42 43
43 protected: 44 protected:
44 ToolbarActionsBarBubbleViewsTest() {} 45 ToolbarActionsBarBubbleViewsTest() {}
45 ~ToolbarActionsBarBubbleViewsTest() override {} 46 ~ToolbarActionsBarBubbleViewsTest() override {}
46 47
48 void SetUp() override {
49 views::ViewsTestBase::SetUp();
50 // Clear any existing layout delegate to avoid a safety DCHECK().
51 views_delegate()->set_layout_delegate(nullptr);
Peter Kasting 2017/04/04 02:08:55 Should no longer be necessary.
52 views_delegate()->set_layout_delegate(
53 base::MakeUnique<ChromeViewsLayoutDelegate>());
54 }
55
47 void TearDown() override { 56 void TearDown() override {
48 anchor_widget_.reset(); 57 anchor_widget_.reset();
49 views::ViewsTestBase::TearDown(); 58 views::ViewsTestBase::TearDown();
50 } 59 }
51 60
52 std::unique_ptr<views::Widget> CreateAnchorWidget() { 61 std::unique_ptr<views::Widget> CreateAnchorWidget() {
53 std::unique_ptr<views::Widget> anchor_widget(new views::Widget()); 62 std::unique_ptr<views::Widget> anchor_widget(new views::Widget());
54 views::Widget::InitParams params = 63 views::Widget::InitParams params =
55 CreateParams(views::Widget::InitParams::TYPE_WINDOW); 64 CreateParams(views::Widget::InitParams::TYPE_WINDOW);
56 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 65 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 } else { 417 } else {
409 EXPECT_TRUE(gfx::test::AreImagesEqual( 418 EXPECT_TRUE(gfx::test::AreImagesEqual(
410 gfx::Image(static_cast<const views::ImageView*>(v)->GetImage()), 419 gfx::Image(static_cast<const views::ImageView*>(v)->GetImage()),
411 gfx::Image(gfx::CreateVectorIcon(ui::kBusinessIcon, kIconSize, 420 gfx::Image(gfx::CreateVectorIcon(ui::kBusinessIcon, kIconSize,
412 gfx::kChromeIconGrey)))); 421 gfx::kChromeIconGrey))));
413 } 422 }
414 } 423 }
415 424
416 CloseBubble(); 425 CloseBubble();
417 } 426 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698