Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/ui/views/page_info/page_info_popup_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Deleted LayoutDelegate and HarmonyLayoutDelegate. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/page_info/page_info_popup_view.h" 5 #include "chrome/browser/ui/views/page_info/page_info_popup_view.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/i18n/rtl.h" 12 #include "base/i18n/rtl.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/strings/string16.h" 15 #include "base/strings/string16.h"
16 #include "base/strings/string_util.h" 16 #include "base/strings/string_util.h"
17 #include "base/strings/utf_string_conversions.h" 17 #include "base/strings/utf_string_conversions.h"
18 #include "chrome/browser/certificate_viewer.h" 18 #include "chrome/browser/certificate_viewer.h"
19 #include "chrome/browser/infobars/infobar_service.h" 19 #include "chrome/browser/infobars/infobar_service.h"
20 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/browser/ui/browser.h" 21 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/browser_dialogs.h" 22 #include "chrome/browser/ui/browser_dialogs.h"
23 #include "chrome/browser/ui/layout_constants.h" 23 #include "chrome/browser/ui/layout_constants.h"
24 #include "chrome/browser/ui/page_info/page_info.h" 24 #include "chrome/browser/ui/page_info/page_info.h"
25 #include "chrome/browser/ui/views/collected_cookies_views.h" 25 #include "chrome/browser/ui/views/collected_cookies_views.h"
26 #include "chrome/browser/ui/views/harmony/chrome_typography.h" 26 #include "chrome/browser/ui/views/harmony/chrome_typography.h"
27 #include "chrome/browser/ui/views/harmony/layout_delegate.h" 27 #include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
28 #include "chrome/browser/ui/views/page_info/chosen_object_row.h" 28 #include "chrome/browser/ui/views/page_info/chosen_object_row.h"
29 #include "chrome/browser/ui/views/page_info/non_accessible_image_view.h" 29 #include "chrome/browser/ui/views/page_info/non_accessible_image_view.h"
30 #include "chrome/browser/ui/views/page_info/permission_selector_row.h" 30 #include "chrome/browser/ui/views/page_info/permission_selector_row.h"
31 #include "chrome/common/url_constants.h" 31 #include "chrome/common/url_constants.h"
32 #include "chrome/grit/chromium_strings.h" 32 #include "chrome/grit/chromium_strings.h"
33 #include "chrome/grit/generated_resources.h" 33 #include "chrome/grit/generated_resources.h"
34 #include "chrome/grit/theme_resources.h" 34 #include "chrome/grit/theme_resources.h"
35 #include "components/content_settings/core/common/content_settings_types.h" 35 #include "components/content_settings/core/common/content_settings_types.h"
36 #include "components/strings/grit/components_chromium_strings.h" 36 #include "components/strings/grit/components_chromium_strings.h"
37 #include "components/strings/grit/components_strings.h" 37 #include "components/strings/grit/components_strings.h"
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 NOTREACHED(); 301 NOTREACHED();
302 } 302 }
303 303
304 // Compensate for built-in vertical padding in the anchor view's image. 304 // Compensate for built-in vertical padding in the anchor view's image.
305 set_anchor_view_insets(gfx::Insets( 305 set_anchor_view_insets(gfx::Insets(
306 GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0)); 306 GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
307 307
308 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing, 308 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing,
309 kSpacing, kSpacing)); 309 kSpacing, kSpacing));
310 set_margins(gfx::Insets()); 310 set_margins(gfx::Insets());
311 if (LayoutDelegate::Get()->ShouldShowWindowIcon()) { 311 if (ChromeViewsLayoutDelegate::Get()->ShouldShowWindowIcon()) {
312 views::ImageView* icon_view = new NonAccessibleImageView(); 312 views::ImageView* icon_view = new NonAccessibleImageView();
313 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 313 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
314 icon_view->SetImage(rb.GetImageSkiaNamed(icon)); 314 icon_view->SetImage(rb.GetImageSkiaNamed(icon));
315 AddChildView(icon_view); 315 AddChildView(icon_view);
316 } 316 }
317 317
318 views::Label* label = new views::Label(l10n_util::GetStringUTF16(text)); 318 views::Label* label = new views::Label(l10n_util::GetStringUTF16(text));
319 label->SetMultiLine(true); 319 label->SetMultiLine(true);
320 label->SetAllowCharacterBreak(true); 320 label->SetAllowCharacterBreak(true);
321 label->SetHorizontalAlignment(gfx::ALIGN_LEFT); 321 label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 layout->AddPaddingRow(1, kHeaderMarginBottom); 429 layout->AddPaddingRow(1, kHeaderMarginBottom);
430 layout->StartRow(1, content_column); 430 layout->StartRow(1, content_column);
431 431
432 site_settings_view_ = CreateSiteSettingsView(side_margin); 432 site_settings_view_ = CreateSiteSettingsView(side_margin);
433 layout->AddView(site_settings_view_); 433 layout->AddView(site_settings_view_);
434 434
435 if (!ui::MaterialDesignController::IsSecondaryUiMaterial()) { 435 if (!ui::MaterialDesignController::IsSecondaryUiMaterial()) {
436 // In non-material, titles are inset from the dialog margin. Ensure the 436 // In non-material, titles are inset from the dialog margin. Ensure the
437 // horizontal insets match. 437 // horizontal insets match.
438 set_title_margins( 438 set_title_margins(
439 gfx::Insets(LayoutDelegate::Get()->GetMetric( 439 gfx::Insets(ChromeViewsLayoutDelegate::Get()->GetDistanceMetric(
440 LayoutDelegate::Metric::PANEL_CONTENT_MARGIN), 440 ChromeDistanceMetric::PANEL_CONTENT_MARGIN),
441 side_margin, 0, side_margin)); 441 side_margin, 0, side_margin));
442 } 442 }
443 views::BubbleDialogDelegateView::CreateBubble(this); 443 views::BubbleDialogDelegateView::CreateBubble(this);
444 444
445 presenter_.reset(new PageInfo( 445 presenter_.reset(new PageInfo(
446 this, profile, TabSpecificContentSettings::FromWebContents(web_contents), 446 this, profile, TabSpecificContentSettings::FromWebContents(web_contents),
447 web_contents, url, security_info)); 447 web_contents, url, security_info));
448 } 448 }
449 449
450 void PageInfoPopupView::RenderFrameDeleted( 450 void PageInfoPopupView::RenderFrameDeleted(
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 PageInfo::PAGE_INFO_CONNECTION_HELP_OPENED); 745 PageInfo::PAGE_INFO_CONNECTION_HELP_OPENED);
746 break; 746 break;
747 case STYLED_LABEL_RESET_CERTIFICATE_DECISIONS: 747 case STYLED_LABEL_RESET_CERTIFICATE_DECISIONS:
748 presenter_->OnRevokeSSLErrorBypassButtonPressed(); 748 presenter_->OnRevokeSSLErrorBypassButtonPressed();
749 GetWidget()->Close(); 749 GetWidget()->Close();
750 break; 750 break;
751 default: 751 default:
752 NOTREACHED(); 752 NOTREACHED();
753 } 753 }
754 } 754 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698