Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Fix various unit-tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "build/build_config.h" 12 #include "build/build_config.h"
13 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 13 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
14 #include "chrome/browser/signin/fake_signin_manager_builder.h" 14 #include "chrome/browser/signin/fake_signin_manager_builder.h"
15 #include "chrome/browser/signin/signin_manager_factory.h" 15 #include "chrome/browser/signin/signin_manager_factory.h"
16 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h" 16 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"
17 #include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
Peter Kasting 2017/03/30 00:49:04 Nit: Additions no longer needed?
kylix_rd 2017/03/30 19:34:07 Done.
17 #include "chrome/test/base/browser_with_test_window_test.h" 18 #include "chrome/test/base/browser_with_test_window_test.h"
18 #include "components/bookmarks/browser/bookmark_utils.h" 19 #include "components/bookmarks/browser/bookmark_utils.h"
19 #include "components/bookmarks/test/bookmark_test_helpers.h" 20 #include "components/bookmarks/test/bookmark_test_helpers.h"
20 #include "components/signin/core/browser/signin_manager.h" 21 #include "components/signin/core/browser/signin_manager.h"
22 #include "ui/views/test/test_views_delegate.h"
21 23
22 using bookmarks::BookmarkModel; 24 using bookmarks::BookmarkModel;
23 25
24 namespace { 26 namespace {
25 const char kTestBookmarkURL[] = "http://www.google.com"; 27 const char kTestBookmarkURL[] = "http://www.google.com";
26 } // namespace 28 } // namespace
27 29
28 class BookmarkBubbleViewTest : public BrowserWithTestWindowTest { 30 class BookmarkBubbleViewTest : public BrowserWithTestWindowTest {
29 public: 31 public:
30 BookmarkBubbleViewTest() {} 32 BookmarkBubbleViewTest() {}
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 TEST_F(BookmarkBubbleViewTest, SyncPromoNotSignedIn) { 97 TEST_F(BookmarkBubbleViewTest, SyncPromoNotSignedIn) {
96 CreateBubbleView(); 98 CreateBubbleView();
97 bubble_->Init(); 99 bubble_->Init();
98 std::unique_ptr<views::View> footnote(bubble_->CreateFootnoteView()); 100 std::unique_ptr<views::View> footnote(bubble_->CreateFootnoteView());
99 #if defined(OS_CHROMEOS) 101 #if defined(OS_CHROMEOS)
100 EXPECT_FALSE(footnote); 102 EXPECT_FALSE(footnote);
101 #else // !defined(OS_CHROMEOS) 103 #else // !defined(OS_CHROMEOS)
102 EXPECT_TRUE(footnote); 104 EXPECT_TRUE(footnote);
103 #endif 105 #endif
104 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698