Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Fix various unit-tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "base/strings/utf_string_conversions.h" 13 #include "base/strings/utf_string_conversions.h"
14 #include "chrome/app/chrome_command_ids.h" 14 #include "chrome/app/chrome_command_ids.h"
15 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 15 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
16 #include "chrome/browser/platform_util.h" 16 #include "chrome/browser/platform_util.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/ui/bookmarks/bookmark_bubble_observer.h" 18 #include "chrome/browser/ui/bookmarks/bookmark_bubble_observer.h"
19 #include "chrome/browser/ui/bookmarks/bookmark_editor.h" 19 #include "chrome/browser/ui/bookmarks/bookmark_editor.h"
20 #include "chrome/browser/ui/browser_dialogs.h" 20 #include "chrome/browser/ui/browser_dialogs.h"
21 #include "chrome/browser/ui/sync/sync_promo_ui.h" 21 #include "chrome/browser/ui/sync/sync_promo_ui.h"
22 #include "chrome/browser/ui/views/harmony/layout_delegate.h" 22 #include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
23 #include "chrome/browser/ui/views/sync/bubble_sync_promo_view.h" 23 #include "chrome/browser/ui/views/sync/bubble_sync_promo_view.h"
24 #include "chrome/grit/chromium_strings.h" 24 #include "chrome/grit/chromium_strings.h"
25 #include "chrome/grit/generated_resources.h" 25 #include "chrome/grit/generated_resources.h"
26 #include "components/bookmarks/browser/bookmark_model.h" 26 #include "components/bookmarks/browser/bookmark_model.h"
27 #include "components/bookmarks/browser/bookmark_utils.h" 27 #include "components/bookmarks/browser/bookmark_utils.h"
28 #include "components/strings/grit/components_strings.h" 28 #include "components/strings/grit/components_strings.h"
29 #include "ui/accessibility/ax_node_data.h" 29 #include "ui/accessibility/ax_node_data.h"
30 #include "ui/base/l10n/l10n_util.h" 30 #include "ui/base/l10n/l10n_util.h"
31 #include "ui/events/keycodes/keyboard_codes.h" 31 #include "ui/events/keycodes/keyboard_codes.h"
32 #include "ui/views/bubble/bubble_frame_view.h" 32 #include "ui/views/bubble/bubble_frame_view.h"
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 parent_combobox_->SetAccessibleName( 171 parent_combobox_->SetAccessibleName(
172 l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_BUBBLE_FOLDER_TEXT)); 172 l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_BUBBLE_FOLDER_TEXT));
173 173
174 GridLayout* layout = new GridLayout(this); 174 GridLayout* layout = new GridLayout(this);
175 SetLayoutManager(layout); 175 SetLayoutManager(layout);
176 176
177 // This column set is used for the labels and textfields as well as the 177 // This column set is used for the labels and textfields as well as the
178 // buttons at the bottom. 178 // buttons at the bottom.
179 const int cs_id = 0; 179 const int cs_id = 0;
180 ColumnSet* cs = layout->AddColumnSet(cs_id); 180 ColumnSet* cs = layout->AddColumnSet(cs_id);
181 cs->AddColumn(LayoutDelegate::Get()->GetControlLabelGridAlignment(), 181 cs->AddColumn(
182 GridLayout::CENTER, 0, GridLayout::USE_PREF, 0, 0); 182 ChromeViewsLayoutDelegate::Get()->GetControlLabelGridAlignment(),
183 GridLayout::CENTER, 0, GridLayout::USE_PREF, 0, 0);
183 cs->AddPaddingColumn(0, views::kUnrelatedControlHorizontalSpacing); 184 cs->AddPaddingColumn(0, views::kUnrelatedControlHorizontalSpacing);
184 185
185 cs->AddColumn(GridLayout::FILL, GridLayout::CENTER, 0, 186 cs->AddColumn(GridLayout::FILL, GridLayout::CENTER, 0,
186 GridLayout::USE_PREF, 0, 0); 187 GridLayout::USE_PREF, 0, 0);
187 cs->AddPaddingColumn(1, views::kUnrelatedControlLargeHorizontalSpacing); 188 cs->AddPaddingColumn(1, views::kUnrelatedControlLargeHorizontalSpacing);
188 189
189 cs->AddColumn(GridLayout::LEADING, GridLayout::TRAILING, 0, 190 cs->AddColumn(GridLayout::LEADING, GridLayout::TRAILING, 0,
190 GridLayout::USE_PREF, 0, 0); 191 GridLayout::USE_PREF, 0, 0);
191 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); 192 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
192 cs->AddColumn(GridLayout::LEADING, GridLayout::TRAILING, 0, 193 cs->AddColumn(GridLayout::LEADING, GridLayout::TRAILING, 0,
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 if (node) { 347 if (node) {
347 const base::string16 new_title = title_tf_->text(); 348 const base::string16 new_title = title_tf_->text();
348 if (new_title != node->GetTitle()) { 349 if (new_title != node->GetTitle()) {
349 model->SetTitle(node, new_title); 350 model->SetTitle(node, new_title);
350 base::RecordAction( 351 base::RecordAction(
351 UserMetricsAction("BookmarkBubble_ChangeTitleInBubble")); 352 UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
352 } 353 }
353 parent_model_.MaybeChangeParent(node, parent_combobox_->selected_index()); 354 parent_model_.MaybeChangeParent(node, parent_combobox_->selected_index());
354 } 355 }
355 } 356 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698