Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/ui/views/harmony/layout_delegate.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Fix Bookmark and Global error unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/harmony/layout_delegate.h" 5 #include "chrome/browser/ui/views/harmony/layout_delegate.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/views/chrome_views_delegate.h" 9 #include "chrome/browser/ui/views/chrome_views_delegate.h"
10 #include "chrome/browser/ui/views/harmony/chrome_typography.h" 10 #include "chrome/browser/ui/views/harmony/chrome_typography.h"
11 #include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
11 #include "chrome/browser/ui/views/harmony/harmony_layout_delegate.h" 12 #include "chrome/browser/ui/views/harmony/harmony_layout_delegate.h"
12 #include "ui/base/material_design/material_design_controller.h" 13 #include "ui/base/material_design/material_design_controller.h"
13 #include "ui/views/layout/layout_constants.h" 14 #include "ui/views/layout/layout_constants.h"
15 #include "ui/views/layout/views_layout_delegate.h"
14 16
15 static base::LazyInstance<LayoutDelegate>::DestructorAtExit layout_delegate_ = 17 static base::LazyInstance<LayoutDelegate>::DestructorAtExit layout_delegate_ =
16 LAZY_INSTANCE_INITIALIZER; 18 LAZY_INSTANCE_INITIALIZER;
17 19
18 // static 20 // static
19 LayoutDelegate* LayoutDelegate::Get() { 21 LayoutDelegate* LayoutDelegate::Get() {
20 return ui::MaterialDesignController::IsSecondaryUiMaterial() 22 return ui::MaterialDesignController::IsSecondaryUiMaterial()
21 ? HarmonyLayoutDelegate::Get() 23 ? HarmonyLayoutDelegate::Get()
22 : layout_delegate_.Pointer(); 24 : layout_delegate_.Pointer();
23 } 25 }
24 26
25 int LayoutDelegate::GetMetric(Metric metric) const { 27 int LayoutDelegate::GetMetric(Metric metric) const {
26 switch (metric) { 28 switch (metric) {
27 case Metric::BUTTON_HORIZONTAL_PADDING: 29 case Metric::BUTTON_HORIZONTAL_PADDING:
28 return ChromeViewsDelegate::GetDefaultDistanceMetric( 30 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
29 views::DistanceMetric::BUTTON_HORIZONTAL_PADDING); 31 views::DistanceMetric::BUTTON_HORIZONTAL_PADDING);
30 case Metric::BUTTON_MAX_LINKABLE_WIDTH: 32 case Metric::BUTTON_MAX_LINKABLE_WIDTH:
31 return 0; // Buttons never expand during layout (add padding instead). 33 return 0; // Buttons never expand during layout (add padding instead).
32 case Metric::BUTTON_MINIMUM_WIDTH: 34 case Metric::BUTTON_MINIMUM_WIDTH:
33 return views::kMinimumButtonWidth; 35 return views::kMinimumButtonWidth;
34 case Metric::DIALOG_BUTTON_MARGIN: 36 case Metric::DIALOG_BUTTON_MARGIN:
35 return views::kButtonHEdgeMarginNew; 37 return views::kButtonHEdgeMarginNew;
36 case Metric::DIALOG_BUTTON_MINIMUM_WIDTH: 38 case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
37 return ChromeViewsDelegate::GetDefaultDistanceMetric( 39 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
38 views::DistanceMetric::DIALOG_BUTTON_MINIMUM_WIDTH); 40 views::DistanceMetric::DIALOG_BUTTON_MINIMUM_WIDTH);
39 case Metric::DIALOG_BUTTON_TOP_SPACING: 41 case Metric::DIALOG_BUTTON_TOP_SPACING:
40 return 0; 42 return 0;
41 case Metric::DIALOG_CLOSE_BUTTON_MARGIN: 43 case Metric::DIALOG_CLOSE_BUTTON_MARGIN:
42 return ChromeViewsDelegate::GetDefaultDistanceMetric( 44 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
43 views::DistanceMetric::CLOSE_BUTTON_MARGIN); 45 views::DistanceMetric::CLOSE_BUTTON_MARGIN);
44 case Metric::PANEL_CONTENT_MARGIN: 46 case Metric::PANEL_CONTENT_MARGIN:
45 return views::kPanelHorizMargin; 47 return views::kPanelHorizMargin;
46 case Metric::RELATED_BUTTON_HORIZONTAL_SPACING: 48 case Metric::RELATED_BUTTON_HORIZONTAL_SPACING:
47 return ChromeViewsDelegate::GetDefaultDistanceMetric( 49 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
48 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL); 50 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL);
49 case Metric::RELATED_CONTROL_HORIZONTAL_SPACING: 51 case Metric::RELATED_CONTROL_HORIZONTAL_SPACING:
50 return ChromeViewsDelegate::GetDefaultDistanceMetric( 52 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
51 views::DistanceMetric::RELATED_CONTROL_HORIZONTAL); 53 views::DistanceMetric::RELATED_CONTROL_HORIZONTAL);
52 case Metric::RELATED_CONTROL_VERTICAL_SPACING: 54 case Metric::RELATED_CONTROL_VERTICAL_SPACING:
53 return ChromeViewsDelegate::GetDefaultDistanceMetric( 55 return ChromeViewsLayoutDelegate::Get()->GetDefaultDistanceMetric(
54 views::DistanceMetric::RELATED_CONTROL_VERTICAL); 56 views::DistanceMetric::RELATED_CONTROL_VERTICAL);
55 case Metric::RELATED_LABEL_HORIZONTAL_SPACING: 57 case Metric::RELATED_LABEL_HORIZONTAL_SPACING:
56 return views::kItemLabelSpacing; 58 return views::kItemLabelSpacing;
57 case Metric::SUBSECTION_HORIZONTAL_INDENT: 59 case Metric::SUBSECTION_HORIZONTAL_INDENT:
58 return views::kCheckboxIndent; 60 return views::kCheckboxIndent;
59 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING: 61 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING:
60 return views::kUnrelatedControlHorizontalSpacing; 62 return views::kUnrelatedControlHorizontalSpacing;
61 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE: 63 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE:
62 return views::kUnrelatedControlLargeHorizontalSpacing; 64 return views::kUnrelatedControlLargeHorizontalSpacing;
63 case Metric::UNRELATED_CONTROL_VERTICAL_SPACING: 65 case Metric::UNRELATED_CONTROL_VERTICAL_SPACING:
(...skipping 25 matching lines...) Expand all
89 int LayoutDelegate::GetDialogPreferredWidth(DialogWidth width) const { 91 int LayoutDelegate::GetDialogPreferredWidth(DialogWidth width) const {
90 return 0; 92 return 0;
91 } 93 }
92 94
93 const views::TypographyProvider& LayoutDelegate::GetTypographyProvider() const { 95 const views::TypographyProvider& LayoutDelegate::GetTypographyProvider() const {
94 // This is not a data member because then HarmonyLayoutDelegate would inherit 96 // This is not a data member because then HarmonyLayoutDelegate would inherit
95 // it, even when it provides its own. 97 // it, even when it provides its own.
96 CR_DEFINE_STATIC_LOCAL(LegacyTypographyProvider, legacy_provider, ()); 98 CR_DEFINE_STATIC_LOCAL(LegacyTypographyProvider, legacy_provider, ());
97 return legacy_provider; 99 return legacy_provider;
98 } 100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698