Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2760)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java

Issue 2758313002: Implement the new Photo picker, part two. (Closed)
Patch Set: Address Ted's comments (and sync to latest) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
index 0c976dda2e1873bef8a4cdfac1829bfe7d6a3ef9..f442710e6c0dd290c7570de52e0d0a15de333f1d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
@@ -31,6 +31,7 @@ import org.chromium.chrome.browser.identity.UuidBasedUniqueIdentificationGenerat
import org.chromium.chrome.browser.invalidation.UniqueIdInvalidationClientNameGenerator;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
+import org.chromium.chrome.browser.photo_picker.PhotoPickerDialog;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.rlz.RevenueStats;
import org.chromium.chrome.browser.services.AccountsChangedReceiver;
@@ -42,7 +43,6 @@ import org.chromium.printing.PrintDocumentAdapterWrapper;
import org.chromium.printing.PrintingControllerImpl;
import org.chromium.ui.PhotoPickerListener;
import org.chromium.ui.UiUtils;
-import org.chromium.ui.widget.Toast;
/**
* Handles the initialization dependences of the browser process. This is meant to handle the
@@ -159,15 +159,20 @@ public class ProcessInitializationHandler {
if (ChromeFeatureList.isEnabled(ChromeFeatureList.NEW_PHOTO_PICKER)) {
UiUtils.setPhotoPickerDelegate(new UiUtils.PhotoPickerDelegate() {
+ private PhotoPickerDialog mDialog;
+
@Override
public void showPhotoPicker(
Context context, PhotoPickerListener listener, boolean allowMultiple) {
- Toast toast = Toast.makeText(context, "Not implemented!", Toast.LENGTH_SHORT);
- toast.show();
+ mDialog = new PhotoPickerDialog(context, listener, allowMultiple);
+ mDialog.show();
}
@Override
- public void dismissPhotoPicker() {}
+ public void dismissPhotoPicker() {
+ mDialog.dismiss();
+ mDialog = null;
+ }
});
}
}

Powered by Google App Engine
This is Rietveld 408576698