chrome/android/java/res/layout/photo_picker_dialog_content.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/photo_picker_dialog_content.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Polish Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2016 The Chromium Authors. All rights reserved.
	Theresa 2017/03/21 15:37:00 s/2016/2017 s/2016/2017 Finnur 2017/03/27 16:50:41 Redundant, file is gone. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > s/2016/2017 Redundant, file is gone.
	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <LinearLayout

	9 xmlns:android="http://schemas.android.com/apk/res/android"

	10 android:layout_width="fill_parent"

	11 android:layout_height="fill_parent"

	12 android:id="@+id/layout"
	Theresa 2017/03/21 15:37:00 nit: replace "layout" with a more meaningful id. nit: replace "layout" with a more meaningful id. Finnur 2017/03/27 16:50:41 Ditto. Ditto.
	13 android:orientation="vertical">

	14 </LinearLayout>

OLD	NEW