Implement the new Photo picker, part two.

chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmap.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.photo_picker;
+
+/**
+ * A class to keep track of the meta data associated with a an image in the

[Ted C, 2017/04/06 23:52:15]

wrap javadoc lines to 100

[Finnur, 2017/04/07 13:52:21]

Done.

+ * photo picker.
+ */
+public class PickerBitmap implements Comparable<PickerBitmap> {
+    // The possible types of tiles involved in the viewer.
+    public enum TileTypes { PICTURE, CAMERA, GALLERY }

[Ted C, 2017/04/06 23:52:15]

We typically try to avoid using enums in java land.  Any thought on using ints
and a corresponding @IntDef here?

[Finnur, 2017/04/07 13:52:20]

Done.

+
+    // The file path to the bitmap to show.
+    private String mFilePath;
+
+    // When the bitmap was last modified on disk.
+    private long mLastModified;
+
+    // The type of tile involved.
+    private TileTypes mType;
+
+    /**
+     * The PickerBitmap constructor.
+     * @param filePath The file path to the bitmap to show.
+     * @param lastModified When the bitmap was last modified on disk.
+     * @param type The type of tile involved.
+     */
+    public PickerBitmap(String filePath, long lastModified, TileTypes type) {
+        mFilePath = filePath;
+        mLastModified = lastModified;
+        mType = type;
+    }
+
+    /**
+     * Accessor for the filepath.
+     * @return The file path for this PickerBitmap object.
+     */
+    public String getFilePath() {
+        return mFilePath;
+    }
+
+    /**
+     * Accessor for the tile type.
+     * @return The type of tile involved for this bitmap object.
+     */
+    public TileTypes type() {
+        return mType;
+    }
+
+    /**
+     * A comparison function for PickerBitmaps (results in a last-modified first sort).
+     * @param other The PickerBitmap to compare it to.
+     * @return 0, 1, or -1, depending on which is bigger.
+     */
+    @Override
+    public int compareTo(PickerBitmap other) {
+        if (mLastModified < other.mLastModified) {

[Ted C, 2017/04/06 23:52:15]

could this be:

return ApiCompatibilityUtils.compareLong(other.mLastModified, mLastModified);

?

[Finnur, 2017/04/07 13:52:20]

Done.

+            return 1;
+        } else if (mLastModified > other.mLastModified) {
+            return -1;
+        }
+        return 0;
+    }
+
+    @Override
+    public final int hashCode() {
+        return (mFilePath + mLastModified).hashCode();
+    }
+
+    @Override
+    public boolean equals(Object other) {

[Ted C, 2017/04/06 23:52:15]

Hmm...this seems a bit weird to me.  Why do you need it to do comparison equals
vs variable equals?  I've found that when I do this I'm usually special casing a
behavior into an object class that should likely live in the feature code (I
recently did something similar with search engines and it bit me a week later).

[Finnur, 2017/04/07 13:52:20]

I think I don't need this equals. These objects will always be unique, and I
don't have a need to ever compare them. I was just trying to suppress a FindBugs
error, which is easier with a simple suppress command above.

+        if (other == this) {
+            return true;
+        }
+        if (other instanceof PickerBitmap) {
+            return compareTo((PickerBitmap) other) == 0;
+        }
+        return false;
+    }
+}