chrome/android/java/res/layout/picker_bitmap_view.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/picker_bitmap_view.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Address Theresa's feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/drawable/circle_white.xml ('K') | « chrome/android/java/res/layout/photo_picker_toolbar.xml ('k') | chrome/android/java/res/menu/photo_picker_menu.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2017 The Chromium Authors. All rights reserved.
	Theresa 2017/04/06 15:13:52 nit: photo_picker_bitmap_view.xml for consistency nit: photo_picker_bitmap_view.xml for consistency with other file names? Finnur 2017/04/06 15:46:47 Done. Show quoted text On 2017/04/06 15:13:52, Theresa wrote: > nit: photo_picker_bitmap_view.xml for consistency with other file names? Done.
	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <!-- Represents a single item in the Photo Picker. -->

	9

	10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView"

	11 xmlns:android="http://schemas.android.com/apk/res/android"

	12 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	13 android:layout_width="wrap_content"

	14 android:layout_height="wrap_content"

	15 android:background="@color/photo_picker_tile_bg_color">

	16

	17 <FrameLayout

	18 android:id="@+id/border"

	19 android:layout_width="wrap_content"

	20 android:layout_height="wrap_content"

	21 android:layout_gravity="center">

	22

	23 <ImageView

	24 android:id="@+id/bitmap_view"

	25 android:layout_width="wrap_content"

	26 android:layout_height="wrap_content"

	27 android:contentDescription="@null" />

	28 </FrameLayout>

	29

	30 <!-- Special tiles, that give access to the camera and gallery -->

	31 <TextView

	32 android:id="@+id/special_tile"

	33 android:layout_width="match_parent"

	34 android:layout_height="wrap_content"

	35 android:layout_marginTop="@dimen/photo_picker_label_gap"

	36 android:drawablePadding="10dp"

	37 android:fontFamily="sans-serif-medium"

	38 android:textStyle="bold"

	39 android:textSize="14sp"

	40 android:textAllCaps="true"

	41 android:textColor="@color/photo_picker_special_tile_color"

	42 android:gravity="center"

	43 android:layout_gravity="center" />

	44 </view>

OLD	NEW