chrome/android/java/res/layout/picker_bitmap_view.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/picker_bitmap_view.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Address Theresa's feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/photo_picker_toolbar.xml ('k') | chrome/android/java/res/menu/file_picker_menu.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2017 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <!-- Represents a single item in the Photo Picker. -->

	9

	10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView"

	11 xmlns:android="http://schemas.android.com/apk/res/android"

	12 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	13 android:layout_width="wrap_content"

	14 android:layout_height="wrap_content">

	15

	16 <RelativeLayout

	17 android:layout_width="wrap_content"

	18 android:layout_height="wrap_content"

	19 android:focusable="true"

	20 android:layout_gravity="center">
	Theresa 2017/04/05 15:48:24 I think that this RelativeLayout probably isn't ne I think that this RelativeLayout probably isn't necessary since none of the relative layout specific things are used on the child views. Can you please try moving the android:layout_gravity param to PickerBitmapView and removing this RelativeLayout? Finnur 2017/04/06 13:22:04 Done. Moved layout_gravity to the two items that n Done. Moved layout_gravity to the two items that need it, instead of doing it in code. Seemed simpler that way.
	21

	22 <FrameLayout

	23 android:id="@+id/border"

	24 android:layout_width="wrap_content"

	25 android:layout_height="wrap_content">

	26

	27 <ImageView

	28 android:id="@+id/bitmap_view"

	29 android:layout_width="wrap_content"

	30 android:layout_height="wrap_content"

	31 android:contentDescription="@null" />

	32 </FrameLayout>

	33

	34 <!-- Special tiles, that give access to the camera and gallery -->

	35 <TextView

	36 android:id="@+id/special_tile"

	37 android:layout_width="match_parent"

	38 android:layout_height="wrap_content"

	39 android:layout_marginTop="@dimen/file_picker_label_gap"

	40 android:drawablePadding="10dp"

	41 android:fontFamily="sans-serif-medium"

	42 android:textStyle="bold"

	43 android:textSize="14sp"

	44 android:textAllCaps="true"

	45 android:textColor="@color/file_picker_special_tile_color"

	46 android:gravity="center" />

	47

	48 </RelativeLayout>

	49 </view>

OLD	NEW