chrome/android/java/res/menu/file_picker_menu.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/menu/file_picker_menu.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Fix scrim color Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <menu xmlns:android="http://schemas.android.com/apk/res/android"

	7 xmlns:chrome="http://schemas.android.com/apk/res-auto" >

	8

	9 <group android:id="@+id/file_picker_normal_menu_group" >

	10 <item

	11 android:id="@+id/close_menu_id"

	12 android:icon="@drawable/btn_close"

	13 android:title="@string/close"

	14 chrome:showAsAction="ifRoom" />

	15 </group>

	16 <group

	17 android:id="@+id/file_picker_selection_mode_menu_group"

	18 android:visible="false" >

	19 <item

	20 android:id="@+id/selection_mode_done_menu_id"

	21 android:title="@string/done"

	22 android:textColor="#55555555"
	Theresa 2017/03/28 20:40:27 Ideally this menu item would not have a custom col Ideally this menu item would not have a custom colors for the toolbar text and would rather use consistent styling with our other selectable lists of things. In the spec this looks white to me. Finnur 2017/03/31 14:26:49 Done. (Removed the custom color). Done. (Removed the custom color).
	23 chrome:showAsAction="always" />

	24 </group>

	25 </menu>

OLD	NEW