Chromium Code Reviews Chromium Code Reviews
Issue 2758313002:
Implement the new Photo picker, part two. (Closed)
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <?xml version="1.0" encoding="utf-8"?> | |
| 2 <!-- | |
| 3 Copyright 2017 The Chromium Authors. All rights reserved. | |
| 4 Use of this source code is governed by a BSD-style license that can be | |
| 5 found in the LICENSE file. | |
| 6 --> | |
| 7 | |
| 8 <!-- Represents a single item in the Photo Picker. --> | |
| 9 | |
| 10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView" | |
| 11 xmlns:android="http://schemas.android.com/apk/res/android" | |
| 12 android:layout_width="wrap_content" | |
| 13 android:layout_height="wrap_content" | |
| 14 android:background="@color/file_picker_tile_bg_color"> | |
| 15 | |
| 16 <RelativeLayout | |
| 17 android:layout_width="wrap_content" | |
| 18 android:layout_height="wrap_content" | |
| 19 android:focusable="true" | |
| 20 android:orientation="vertical"> | |
|
Theresa
2017/03/28 20:40:27
android:orientation is used with LinearLayout not
Finnur
2017/03/31 14:26:48
Done.
| |
| 21 | |
| 22 <FrameLayout | |
| 23 android:id="@+id/border" | |
| 24 android:layout_width="wrap_content" | |
| 25 android:layout_height="wrap_content"> | |
| 26 | |
| 27 <ImageView | |
| 28 android:id="@+id/bitmap_view" | |
| 29 android:layout_width="wrap_content" | |
| 30 android:layout_height="wrap_content" | |
| 31 android:contentDescription="@null" /> | |
| 32 | |
| 33 <View | |
| 34 android:id="@+id/scrim" | |
| 35 android:layout_width="64dp" | |
| 36 android:layout_height="64dp" | |
| 37 android:background="@drawable/file_picker_scrim" | |
| 38 android:visibility="gone" /> | |
| 39 </FrameLayout> | |
| 40 | |
| 41 <ImageView | |
| 42 android:id="@+id/selected" | |
| 43 android:layout_width="wrap_content" | |
| 44 android:layout_height="wrap_content" | |
| 45 android:layout_marginStart="4dp" | |
| 46 android:layout_marginTop="4dp" | |
| 47 android:background="@drawable/file_picker_selected_background" | |
| 48 android:elevation="2dp" | |
| 49 android:contentDescription="@string/clear_cookies_and_site_data_titl e" | |
| 50 android:visibility="gone" /> | |
| 51 <ImageView | |
|
Theresa
2017/03/28 20:40:27
nit: add a blank line above this one
Finnur
2017/03/31 14:26:48
Done.
| |
| 52 android:id="@+id/unselected" | |
| 53 android:layout_width="wrap_content" | |
| 54 android:layout_height="wrap_content" | |
| 55 android:layout_marginStart="4dp" | |
| 56 android:layout_marginTop="4dp" | |
| 57 android:contentDescription="@string/clear_cookies_and_site_data_titl e" | |
| 58 android:visibility="gone" /> | |
| 59 | |
| 60 <!-- Special tiles, that give access to the camera and gallery --> | |
| 61 <TextView | |
| 62 android:id="@+id/special_tile" | |
| 63 android:layout_width="match_parent" | |
| 64 android:layout_height="wrap_content" | |
| 65 android:layout_marginTop="@dimen/file_picker_label_gap" | |
| 66 android:drawablePadding="10dp" | |
| 67 android:fontFamily="sans-serif-medium" | |
| 68 android:textStyle="bold" | |
| 69 android:textSize="14sp" | |
| 70 android:textAllCaps="true" | |
| 71 android:textColor="@color/file_picker_special_tile_color" | |
| 72 android:gravity="center" | |
| 73 android:layout_centerInParent="true" /> | |
| 74 | |
| 75 </RelativeLayout> | |
| 76 </view> | |
| OLD | NEW |
