chrome/android/java/res/drawable/file_picker_selected_background.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/file_picker_selected_background.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Fix scrim color Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <inset xmlns:android="http://schemas.android.com/apk/res/android"
	Theresa 2017/03/28 20:40:26 When this background is combined with ic_check_cir When this background is combined with ic_check_circle_black_24dp, it looks verify_checkmark.png, right? Can we just use that asset? Finnur 2017/03/31 14:26:48 Good catch! Done. Good catch! Done.
	7 android:insetLeft="2dp"

	8 android:insetTop="2dp"

	9 android:insetRight="2dp"

	10 android:insetBottom="2dp">

	11 <shape xmlns:android="http://schemas.android.com/apk/res/android" android:sh ape="oval">

	12 <size

	13 android:width="20dp"

	14 android:height="20dp" />

	15 <solid android:color="@android:color/white" />

	16 </shape>

	17 </inset>

OLD	NEW