Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 27583002: Add PRESUBMIT.py to libc++ (Closed)

Created:
7 years, 2 months ago by JF
Modified:
7 years, 2 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-libcxx.git@master
Visibility:
Public.

Description

Add PRESUBMIT.py to libc++ Prevents us from failed pushes, which then require git push origin master:master to clean up. R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-libcxx.git;a=commit;h=e5366e4

Patch Set 1 #

Patch Set 2 : Failed uploading. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
A PRESUBMIT.py View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
JF
7 years, 2 months ago (2013-10-16 20:59:44 UTC) #1
Derek Schuff
On 2013/10/16 20:59:44, JF wrote: LGTM
7 years, 2 months ago (2013-10-16 21:53:31 UTC) #2
JF
7 years, 2 months ago (2013-10-16 21:56:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as re5366e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698