third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h - Issue 2758233003: Fix the conditions when fullscreen detector listeners are registered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

Issue 2758233003: Fix the conditions when fullscreen detector listeners are registered (Closed)

Patch Set: addressed mlamouri's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLVideoElement.cpp ('k') | third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

diff --git a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

index 316c74bea0d43c8a5f5370321da3e80f041c6ba5..4ef096f1d8291421e8a733321660d8275573956f 100644

--- a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

+++ b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h

@@ -25,6 +25,8 @@ class CORE_EXPORT MediaCustomControlsFullscreenDetector final

// EventListener implementation.

bool operator==(const EventListener&) const override;

+ void attach();

+ void detach();

void contextDestroyed();

DECLARE_VIRTUAL_TRACE();

@@ -36,9 +38,6 @@ class CORE_EXPORT MediaCustomControlsFullscreenDetector final

// EventListener implementation.

void handleEvent(ExecutionContext*, Event*) override;

- void attach();

- void detach();

HTMLVideoElement& videoElement() { return *m_videoElement; }

void onCheckViewportIntersectionTimerFired(TimerBase*);