Fix the conditions when fullscreen detector listeners are registered

third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 61 matching lines @@
   video->suspendIfNeeded();
   return video;
 }
 
 DEFINE_TRACE(HTMLVideoElement) {
   visitor->trace(m_imageLoader);
   visitor->trace(m_customControlsFullscreenDetector);
   HTMLMediaElement::trace(visitor);
 }
 
+Node::InsertionNotificationRequest HTMLVideoElement::insertedInto(
+    ContainerNode* insertionPoint) {
+  if (insertionPoint->isConnected() && m_customControlsFullscreenDetector)
+    m_customControlsFullscreenDetector->attach();
+
+  return HTMLMediaElement::insertedInto(insertionPoint);
+}
+
+void HTMLVideoElement::removedFrom(ContainerNode* insertionPoint) {
+  HTMLMediaElement::removedFrom(insertionPoint);
+
+  if (insertionPoint->inActiveDocument() && m_customControlsFullscreenDetector)

[mlamouri (slow - plz ping), 2017/03/20 17:05:25]

OOC, why are you adding this? I did not really understood why HTMLMediaELement
had this check. MediaControls doesn't have it.

[Zhiqiang Zhang (Slow), 2017/03/20 17:14:22]

The check is to see if the node was connected to an active document before
removing. I think we can remove it as removing unregistered listeners is no-op.

+    m_customControlsFullscreenDetector->detach();
+}
+
 void HTMLVideoElement::contextDestroyed(ExecutionContext* context) {
   if (m_customControlsFullscreenDetector)
     m_customControlsFullscreenDetector->contextDestroyed();
 
   HTMLMediaElement::contextDestroyed(context);
 }
 
 bool HTMLVideoElement::layoutObjectIsNeeded(const ComputedStyle& style) {
   return HTMLElement::layoutObjectIsNeeded(style);
 }
@@ skipping 295 matching lines @@
     return ScriptPromise();
   if (!ImageBitmap::isResizeOptionValid(options, exceptionState))
     return ScriptPromise();
   return ImageBitmapSource::fulfillImageBitmap(
       scriptState,
       ImageBitmap::create(this, cropRect,
                           eventTarget.toLocalDOMWindow()->document(), options));
 }
 
 }  // namespace blink