Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: media/gpu/video_encode_accelerator_unittest.cc

Issue 2758203002: VEA unittest: remove quality test on chromeos temporarily (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/video_encode_accelerator_unittest.cc
diff --git a/media/gpu/video_encode_accelerator_unittest.cc b/media/gpu/video_encode_accelerator_unittest.cc
index 11f019b9b8920f25fe9a4cb6aba7aba87a73efb2..94f1be4c98135560a001e4b7749d47d137988f8a 100644
--- a/media/gpu/video_encode_accelerator_unittest.cc
+++ b/media/gpu/video_encode_accelerator_unittest.cc
@@ -2143,12 +2143,12 @@ TEST_P(VideoEncodeAcceleratorSimpleTest, TestSimpleEncode) {
}
#if defined(OS_CHROMEOS)
+// TODO(kcwu): add back test of verify_output=true after crbug.com/694131 fixed.
Owen Lin 2017/03/20 03:14:57 How about file a new bug for adding this back?
kcwu 2017/03/20 03:33:29 My plan is keeping 694131 open, so unnecessary to
Owen Lin 2017/03/20 06:53:02 It just makes things clear. Maybe we will assign t
kcwu 2017/03/20 07:11:45 I filed a bug to add it back. https://bugs.chromiu
INSTANTIATE_TEST_CASE_P(
SimpleEncode,
VideoEncodeAcceleratorTest,
::testing::Values(
- std::make_tuple(1, true, 0, false, false, false, false, false, false),
- std::make_tuple(1, true, 0, false, false, false, false, true, false)));
+ std::make_tuple(1, true, 0, false, false, false, false, false, false)));
Owen Lin 2017/03/20 03:14:57 Why not filter out the test in autotest? My point
kcwu 2017/03/20 03:33:29 I am also considering filter out in autotest. My r
Owen Lin 2017/03/20 06:53:02 Acknowledged. I think (1) is a good reason. But ab
INSTANTIATE_TEST_CASE_P(
EncoderPerf,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698