chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java - Issue 2758193002: [Android WebAPKs] Don't navigate WebAPK when launching it from launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java

Issue 2758193002: [Android WebAPKs] Don't navigate WebAPK when launching it from launcher (Closed)

Patch Set: Merge branch 'master' into twitter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java

index 96608f7f1cfbb709b3ea4563c818614e58e1c8b1..7ff886c866ca080d49951fba3403abb4e9ffe87d 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java

@@ -73,6 +73,7 @@ public class WebApkInfoTest {

Intent intent = new Intent();

intent.putExtra(

WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME, WebApkTestHelper.WEBAPK_PACKAGE_NAME);

+ intent.putExtra(WebApkConstants.EXTRA_WEBAPK_FORCE_NAVIGATION, true);

intent.putExtra(ShortcutHelper.EXTRA_URL, START_URL);

intent.putExtra(ShortcutHelper.EXTRA_SOURCE, ShortcutSource.NOTIFICATION);

@@ -80,6 +81,8 @@ public class WebApkInfoTest {

Assert.assertEquals(WebApkConstants.WEBAPK_ID_PREFIX + WebApkTestHelper.WEBAPK_PACKAGE_NAME,

info.id());

+ Assert.assertEquals(START_URL, info.uri().toString());

+ Assert.assertTrue(info.shouldForceNavigation());

Assert.assertEquals(SCOPE, info.scopeUri().toString());

Assert.assertEquals(NAME, info.name());

Assert.assertEquals(SHORT_NAME, info.shortName());