chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java - Issue 2758193002: [Android WebAPKs] Don't navigate WebAPK when launching it from launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

Issue 2758193002: [Android WebAPKs] Don't navigate WebAPK when launching it from launcher (Closed)

Patch Set: Merge branch 'package_name2' into twitter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

index f12e27f5134968715a4f0f7ff21d8e1358755778..08aefdd3ae692f2da2ec5e01867e7bfcfdc678f0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

@@ -689,8 +689,8 @@ public class ShortcutHelper {

if (WebApkValidator.isValidWebApk(context, packageInfo.packageName)) {

// Pass non-null URL parameter so that {@link WebApkInfo#create()}

// return value is non-null

- WebApkInfo webApkInfo =

- WebApkInfo.create(packageInfo.packageName, "", ShortcutSource.UNKNOWN);

+ WebApkInfo webApkInfo = WebApkInfo.create(

+ packageInfo.packageName, "", false, ShortcutSource.UNKNOWN);

dominickn 2017/03/21 02:09:32 Nit: add /* forceNavigation */ after the boolean p

if (webApkInfo != null) {

names.add(webApkInfo.name());

shortNames.add(webApkInfo.shortName());