net/spdy/spdy_header_block.cc - Issue 2758163003: Use string(StringPiece) instead of StringPiece::as_string().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_header_block.cc

Issue 2758163003: Use string(StringPiece) instead of StringPiece::as_string(). (Closed)

Patch Set: Add StringPiece unittests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_header_block.cc

diff --git a/net/spdy/spdy_header_block.cc b/net/spdy/spdy_header_block.cc

index d3d1fe2b065824017b44968ac17840be6a2a5882..c6ba34e3ed404cca64c800102b7b660f78c93934 100644

--- a/net/spdy/spdy_header_block.cc

+++ b/net/spdy/spdy_header_block.cc

@@ -218,7 +218,7 @@ string SpdyHeaderBlock::ValueProxy::as_string() const {

if (lookup_result_ == block_->end()) {

return "";

} else {

- return lookup_result_->second.value().as_string();

+ return std::string(lookup_result_->second.value());

}

« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | no next file » | no next file with comments »