Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: net/spdy/hpack/hpack_entry.cc

Issue 2758163003: Use string(StringPiece) instead of StringPiece::as_string(). (Closed)
Patch Set: Add StringPiece unittests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/string_piece_unittest.cc ('k') | net/spdy/spdy_deframer_visitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_entry.cc
diff --git a/net/spdy/hpack/hpack_entry.cc b/net/spdy/hpack/hpack_entry.cc
index 8c5d3d436f2c1fce835fb7b9911df5122e4ee4a2..d5c873ff26ca53dac8c3e802aed68283506cb530 100644
--- a/net/spdy/hpack/hpack_entry.cc
+++ b/net/spdy/hpack/hpack_entry.cc
@@ -77,9 +77,9 @@ size_t HpackEntry::Size() const {
}
std::string HpackEntry::GetDebugString() const {
- return "{ name: \"" + name_ref_.as_string() + "\", value: \"" +
- value_ref_.as_string() + "\", index: " +
- base::SizeTToString(insertion_index_) +
+ return "{ name: \"" + std::string(name_ref_) + "\", value: \"" +
+ std::string(value_ref_) +
+ "\", index: " + base::SizeTToString(insertion_index_) +
(IsStatic() ? " static" : (IsLookup() ? " lookup" : " dynamic")) +
" }";
}
« no previous file with comments | « base/strings/string_piece_unittest.cc ('k') | net/spdy/spdy_deframer_visitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698