Don't reset URL for CAN_COMMIT_URL_BLOCKED renderer kill.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 1203 matching lines @@
         base::TimeTicks::Now() - validated_params.ui_timestamp,
         base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(10),
         100);
   }
 
   // Attempts to commit certain off-limits URL should be caught more strictly
   // than our FilterURL checks below.  If a renderer violates this policy, it
   // should be killed.
   if (!CanCommitURL(validated_params.url)) {
     VLOG(1) << "Blocked URL " << validated_params.url.spec();
-    validated_params.url = GURL(url::kAboutBlankURL);
     // Kills the process.
     bad_message::ReceivedBadMessage(process,
                                     bad_message::RFH_CAN_COMMIT_URL_BLOCKED);
+    validated_params.url = GURL(url::kAboutBlankURL);

[nasko, 2017/03/20 21:37:14]

Doing some code archeology, it looks like we might actually not need that line.
We don't have it in the CanCommitOrigin check below, so we should be consistent.

We had to have it before, as there was no return statement in this if block,
which meant that the URL had to be rewritten to be safe. However as part of
https://codereview.chromium.org/1775543002, the return statement is added and
this seems to no longer be needed.

The ordering of dates back from https://chromiumcodereview.appspot.com/15017018,
so it looks like we didn't really get meaningful URLs from this kill all along.

[Charlie Reis, 2017/03/21 18:32:11]

Good call!  Done.

     return;
   }
 
   // Verify that the origin passed from the renderer process is valid and can
   // be allowed to commit in this RenderFrameHost.
   if (!CanCommitOrigin(validated_params.origin, validated_params.url)) {
     bad_message::ReceivedBadMessage(GetProcess(),
                                     bad_message::RFH_INVALID_ORIGIN_ON_COMMIT);
     return;
   }
@@ skipping 2237 matching lines @@
           GetUserData(kRenderFrameHostAndroidKey));
   if (!render_frame_host_android) {
     render_frame_host_android = new RenderFrameHostAndroid(this);
     SetUserData(kRenderFrameHostAndroidKey, render_frame_host_android);
   }
   return render_frame_host_android->GetJavaObject();
 }
 #endif
 
 }  // namespace content