Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 275813004: android: Unset the DelegatedResourceCollection before LoseAllResources. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, Ken Russell (switch to Gerrit), piman, no sievers
Visibility:
Public.

Description

android: Unset the DelegatedResourceCollection before LoseAllResources. This matches the behaviour of the DelegatedFrameHost used by mac and aura, and ensures the RenderWidgetHostViewAndroid does not try to return resources twice since the client callback would be called from LoseAllResources otherwise. R=aelias BUG=372486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270023

Patch Set 1 #

Patch Set 2 : android-ack: enabletest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 7 months ago (2014-05-12 23:39:24 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-05-12 23:41:26 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-12 23:42:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/275813004/1
6 years, 7 months ago (2014-05-12 23:43:25 UTC) #4
danakj
Re-enabling the test in this CL since this should fix it.
6 years, 7 months ago (2014-05-12 23:45:20 UTC) #5
danakj
+tedchoc for chrome/android
6 years, 7 months ago (2014-05-12 23:46:25 UTC) #6
Ted C
lgtm - chrome/android
6 years, 7 months ago (2014-05-12 23:52:09 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-12 23:56:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/275813004/20001
6 years, 7 months ago (2014-05-12 23:59:23 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:08:17 UTC) #10
Message was sent while issue was closed.
Change committed as 270023

Powered by Google App Engine
This is Rietveld 408576698