Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 2758123002: Create a new element for generic function types (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -123 lines) Patch
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 4 chunks +26 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/dart/element/visitor.dart View 4 chunks +17 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 32 chunks +262 lines, -101 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-18 21:40:27 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-18 22:06:27 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-19 17:45:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c56210c294b514c96ea8cfe5a19b7471a0b30c49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698