fasta.PrecedenceInfo implement analyzer.TokenType

fasta.PrecedenceInfo implement analyzer.TokenType

This updates PrecedenceInfo to implement TokenType
so that fasta.Token.type can return info for the token type.

In addition, the TokenType consts are now reference the corresponding
PrecedenceInfo consts so that parsing using either scanner will result
in token types that are identical.

R=ahe@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/8bef633d3f2bdd1a3d776b07cacc786db215673c

[danrubel, 2017-03-18 23:47:22]

danrubel@google.com changed reviewers:
+ ahe@google.com, brianwilkerson@google.com, paulberry@google.com

[ahe, 2017-03-20 12:25:30]

lgtm

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/precedence.dart (right):

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/precedence.dart:248: const
PrecedenceInfo('||', 'BAR_BAR', 5, BAR_BAR_TOKEN, isOperator: true);
The word for barbarian is "barbar" in Danish. So a bar frequented by barbarians
would be a barbar bar.

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/token.dart (right):

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/token.dart:135: bool get
isUserDefinableOperator => info.isUserDefinableOperator;
@override?

[Paul Berry, 2017-03-20 16:42:49]

lgtm

[danrubel, 2017-03-20 17:19:30]

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/precedence.dart (right):

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/precedence.dart:248: const
PrecedenceInfo('||', 'BAR_BAR', 5, BAR_BAR_TOKEN, isOperator: true);
On 2017/03/20 12:25:29, ahe wrote:
> The word for barbarian is "barbar" in Danish. So a bar frequented by
barbarians
> would be a barbar bar.

<chuckle/>

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/token.dart (right):

https://codereview.chromium.org/2758113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/token.dart:135: bool get
isUserDefinableOperator => info.isUserDefinableOperator;
On 2017/03/20 12:25:29, ahe wrote:
> @override?

I can't add that until fasta.Token implements analyzer.Token

[danrubel, 2017-03-20 17:41:05]

Description was changed from

==========
fasta.PrecedenceInfo implement analyzer.TokenType

This updates PrecedenceInfo to implement TokenType
so that fasta.Token.type can return info for the token type.

In addition, the TokenType consts are now reference the corresponding
PrecedenceInfo consts so that parsing using either scanner will result
in token types that are identical.
==========

to

==========
fasta.PrecedenceInfo implement analyzer.TokenType

This updates PrecedenceInfo to implement TokenType
so that fasta.Token.type can return info for the token type.

In addition, the TokenType consts are now reference the corresponding
PrecedenceInfo consts so that parsing using either scanner will result
in token types that are identical.

R=ahe@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8bef633d3f2bdd1a3d776b07cacc786db215673c
==========

[danrubel, 2017-03-20 17:41:06]

Committed patchset #5 (id:80001) manually as
8bef633d3f2bdd1a3d776b07cacc786db215673c (presubmit successful).