Fix LibraryDependencyMirrors when the target is a native extension.

Fix LibraryDependencyMirrors when the target is a native extension.

Fixes #28881.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/54b13e745117c9b56bc105003300f3ba53f9ddb7

[rmacnak, 2017-03-17 20:47:58]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-03-17 21:03:35]

lgtm

[siva, 2017-03-17 21:07:04]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-03-17 21:07:05]

DBC

https://codereview.chromium.org/2758003002/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/2758003002/diff/20001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:450: // A native extension is not "loaded", but doesn't
have a deferred prefix.
The comment here seems opposite to the condition importee.Loaded()?

[rmacnak, 2017-03-17 22:03:32]

https://codereview.chromium.org/2758003002/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/2758003002/diff/20001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:450: // A native extension is not "loaded", but doesn't
have a deferred prefix.
On 2017/03/17 21:07:05, siva wrote:
> The comment here seems opposite to the condition importee.Loaded()?

The first half of the condition gets eagerly loaded libraries or deferred
libraries that have had loadLibrary called. The second half picks up native
extensions.  Clarified in the comment.

[rmacnak, 2017-03-17 23:15:14]

Description was changed from

==========
Fix LibraryDependencyMirrors when the target is a native extension.

Fixes #28881.
==========

to

==========
Fix LibraryDependencyMirrors when the target is a native extension.

Fixes #28881.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/54b13e745117c9b56bc105003300f3ba53f9ddb7
==========

[rmacnak, 2017-03-17 23:15:15]

Committed patchset #3 (id:40001) manually as
54b13e745117c9b56bc105003300f3ba53f9ddb7 (presubmit successful).