Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2757983002: Suppress undefined_getter error when analyzing colors.dart with an older SDK. (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress undefined_getter error when analyzing colors.dart with an older SDK. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/bad0577857f371184ca11c6c40b7f39157111c43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/front_end/lib/src/fasta/colors.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 9 months ago (2017-03-17 20:04:44 UTC) #2
ahe
Thank you. As of today, that getter is gone again: https://codereview.chromium.org/2753233002 I'll make sure to ...
3 years, 9 months ago (2017-03-17 20:07:50 UTC) #3
ahe
lgtm
3 years, 9 months ago (2017-03-17 20:07:55 UTC) #4
Paul Berry
3 years, 9 months ago (2017-03-17 20:46:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bad0577857f371184ca11c6c40b7f39157111c43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698