Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: remoting/protocol/connection_unittest.cc

Issue 2757923004: Fix failed capture handling in WebrtcVideoStream (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/connection_unittest.cc
diff --git a/remoting/protocol/connection_unittest.cc b/remoting/protocol/connection_unittest.cc
index c35278315b397cf2497a4bd4aaa0f2940765f136..ed355526cfe9595064d7a396c9e763e1f5acdcd2 100644
--- a/remoting/protocol/connection_unittest.cc
+++ b/remoting/protocol/connection_unittest.cc
@@ -635,41 +635,15 @@ TEST_P(ConnectionTest, Audio) {
client_audio_player_.Verify();
}
-#if !defined(MEMORY_SANITIZER)
-// Test fails under msan, https://crbug.com/697178
TEST_P(ConnectionTest, FirstCaptureFailed) {
Connect();
- base::TimeTicks event_timestamp = base::TimeTicks::FromInternalValue(42);
-
- scoped_refptr<InputEventTimestampsSourceImpl> input_event_timestamps_source =
- new InputEventTimestampsSourceImpl();
- input_event_timestamps_source->OnEventReceived(
- InputEventTimestamps{event_timestamp, base::TimeTicks::Now()});
-
auto capturer = base::MakeUnique<TestScreenCapturer>();
capturer->FailNthFrame(0);
auto video_stream = host_connection_->StartVideoStream(std::move(capturer));
- video_stream->SetEventTimestampsSource(input_event_timestamps_source);
WaitNextVideoFrame();
-
- // Currently stats work in this test only for WebRTC because for ICE
- // connections stats are reported by SoftwareVideoRenderer which is not used
- // in this test.
- // TODO(sergeyu): Fix this.
- if (is_using_webrtc()) {
- WaitFirstFrameStats();
-
- // Verify that the event timestamp received before the first frame gets used
- // for the second frame.
- const FrameStats& stats = client_video_renderer_.GetFrameStatsConsumer()
- ->received_stats()
- .front();
- EXPECT_EQ(event_timestamp, stats.host_stats.latest_event_timestamp);
- }
}
-#endif
TEST_P(ConnectionTest, SecondCaptureFailed) {
Connect();
« no previous file with comments | « no previous file | remoting/protocol/webrtc_frame_scheduler_simple.h » ('j') | remoting/protocol/webrtc_frame_scheduler_simple.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698