Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 27579004: Make sure envsetup.sh is sourced. (Closed)

Created:
7 years, 2 months ago by skobes
Modified:
7 years, 2 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master.pinned
Visibility:
Public.

Description

Make sure envsetup.sh is sourced. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M build/android/envsetup.sh View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
skobes
7 years, 2 months ago (2013-10-17 00:37:58 UTC) #1
skobes
ping
7 years, 2 months ago (2013-10-18 01:50:19 UTC) #2
Isaac (away)
lgtm, thanks.
7 years, 2 months ago (2013-10-18 05:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/27579004/1
7 years, 2 months ago (2013-10-18 16:54:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31313
7 years, 2 months ago (2013-10-18 20:23:39 UTC) #5
skobes
Hmm, I can't tell if this CQ failure is caused by my change or not. ...
7 years, 2 months ago (2013-10-18 20:27:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/27579004/1
7 years, 2 months ago (2013-10-22 23:32:07 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 03:43:27 UTC) #8
Message was sent while issue was closed.
Change committed as 230307

Powered by Google App Engine
This is Rietveld 408576698