Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: chrome/browser/signin/chrome_signin_client.h

Issue 2757873002: Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_ 5 #ifndef CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_
6 #define CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_ 6 #define CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 net::URLRequestContextGetter* GetURLRequestContext() override; 46 net::URLRequestContextGetter* GetURLRequestContext() override;
47 bool ShouldMergeSigninCredentialsIntoCookieJar() override; 47 bool ShouldMergeSigninCredentialsIntoCookieJar() override;
48 bool IsFirstRun() const override; 48 bool IsFirstRun() const override;
49 base::Time GetInstallDate() override; 49 base::Time GetInstallDate() override;
50 bool AreSigninCookiesAllowed() override; 50 bool AreSigninCookiesAllowed() override;
51 void AddContentSettingsObserver( 51 void AddContentSettingsObserver(
52 content_settings::Observer* observer) override; 52 content_settings::Observer* observer) override;
53 void RemoveContentSettingsObserver( 53 void RemoveContentSettingsObserver(
54 content_settings::Observer* observer) override; 54 content_settings::Observer* observer) override;
55 void DelayNetworkCall(const base::Closure& callback) override; 55 void DelayNetworkCall(const base::Closure& callback) override;
56 GaiaAuthFetcher* CreateGaiaAuthFetcher( 56 std::unique_ptr<GaiaAuthFetcher> CreateGaiaAuthFetcher(
57 GaiaAuthConsumer* consumer, 57 GaiaAuthConsumer* consumer,
58 const std::string& source, 58 const std::string& source,
59 net::URLRequestContextGetter* getter) override; 59 net::URLRequestContextGetter* getter) override;
60 60
61 // Returns a string describing the chrome version environment. Version format: 61 // Returns a string describing the chrome version environment. Version format:
62 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel"> 62 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel">
63 // If version information is unavailable, returns "invalid." 63 // If version information is unavailable, returns "invalid."
64 std::string GetProductVersion() override; 64 std::string GetProductVersion() override;
65 std::unique_ptr<CookieChangedSubscription> AddCookieChangedCallback( 65 std::unique_ptr<CookieChangedSubscription> AddCookieChangedCallback(
66 const GURL& url, 66 const GURL& url,
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 bool is_force_signin_enabled_; 119 bool is_force_signin_enabled_;
120 bool should_display_user_manager_ = true; 120 bool should_display_user_manager_ = true;
121 121
122 std::unique_ptr<gaia::GaiaOAuthClient> oauth_client_; 122 std::unique_ptr<gaia::GaiaOAuthClient> oauth_client_;
123 std::unique_ptr<OAuth2TokenService::Request> oauth_request_; 123 std::unique_ptr<OAuth2TokenService::Request> oauth_request_;
124 124
125 DISALLOW_COPY_AND_ASSIGN(ChromeSigninClient); 125 DISALLOW_COPY_AND_ASSIGN(ChromeSigninClient);
126 }; 126 };
127 127
128 #endif // CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_ 128 #endif // CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698