Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2757863003: Avoid unused Computations in SelectionController::selectClosestWordFromHitTestResult (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index c253d60a8b364671d45f1bfe5f988ce3df32485e..c577d52a40dc46166c99dbad87ba8809869b42b6 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -442,7 +442,8 @@ bool SelectionController::selectClosestWordFromHitTestResult(
Node* innerNode = result.innerNode();
VisibleSelectionInFlatTree newSelection;
- if (!innerNode || !innerNode->layoutObject())
+ if (!innerNode || !innerNode->layoutObject() ||
+ !innerNode->layoutObject()->isSelectable())
return false;
// Special-case image local offset to always be zero, to avoid triggering
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698