SearchTabHelper: Find browser/window instead of having them passed in

chrome/browser/ui/browser_browsertest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 38 matching lines @@
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_ui_prefs.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
 #include "chrome/browser/ui/extensions/app_launch_params.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
+#include "chrome/browser/ui/search/search_tab_helper.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/app_modal/app_modal_dialog.h"
 #include "components/app_modal/app_modal_dialog_queue.h"
 #include "components/app_modal/javascript_app_modal_dialog.h"
 #include "components/app_modal/native_app_modal_dialog.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/omnibox/common/omnibox_focus_state.h"
 #include "components/prefs/pref_service.h"
 #include "components/sessions/core/base_session_service_test_helper.h"
 #include "components/translate/core/browser/language_state.h"
 #include "components/translate/core/common/language_detection_details.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/host_zoom_map.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/navigation_handle.h"
@@ skipping 1421 matching lines @@
       dev_tools_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));
 
   // App windows can show location bars, for example when they navigate away
   // from their starting origin.
   EXPECT_TRUE(
       app_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));
 
   DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
 }
 
+// Regression test for crbug.com/702505.
+IN_PROC_BROWSER_TEST_F(BrowserTest, ReattachDevToolsWindow) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+  WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  GURL ntp_url(search::GetNewTabPageURL(browser()->profile()));

[Peter Kasting, 2017/03/20 20:11:10]

Nit: Prefer = to () in this case; see
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Variab...

[Marc Treib, 2017/03/21 08:49:08]

Done.

+  ui_test_utils::NavigateToURL(browser(), ntp_url);
+
+  // Open a devtools window.
+  DevToolsWindow* devtools_window =
+      DevToolsWindowTesting::OpenDevToolsWindowSync(browser(),
+                                                    /*is_docked=*/true);
+  ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile()));
+
+  // Grab its main web contents.
+  content::WebContents* devtools_main_web_contents =
+      DevToolsWindow::GetInTabWebContents(
+          devtools_window->GetInspectedWebContents(), nullptr);
+  ASSERT_NE(web_contents, devtools_main_web_contents);
+
+  // Detach the devtools window.
+  DevToolsUIBindings::Delegate* devtools_delegate =
+      static_cast<DevToolsUIBindings::Delegate*>(devtools_window);
+  devtools_delegate->SetIsDocked(false);
+
+  // This should have created a new dev tools browser.
+  ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
+
+  // Re-attach the dev tools window. This resets its Browser*.
+  devtools_delegate->SetIsDocked(true);
+  // Wait until the browser actually gets closed.
+  content::RunAllPendingInMessageLoop();
+  ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile()));
+
+  // Do something that will make SearchTabHelper access its OmniboxView. This
+  // should not crash, even though the Browser association and thus the
+  // OmniboxView* has changed, and the old OmniboxVie has been deleted.

[Peter Kasting, 2017/03/20 20:11:10]

Nit: old OmniboxView

[Marc Treib, 2017/03/21 08:49:08]

Done.

+  SearchTabHelper* search_tab_helper =
+      SearchTabHelper::FromWebContents(devtools_main_web_contents);
+  SearchIPCRouter::Delegate* search_ipc_router_delegate =
+      static_cast<SearchIPCRouter::Delegate*>(search_tab_helper);
+  search_ipc_router_delegate->FocusOmnibox(OMNIBOX_FOCUS_INVISIBLE);
+
+  DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
+}
+
 // Chromeos defaults to restoring the last session, so this test isn't
 // applicable.
 #if !defined(OS_CHROMEOS)
 // Makes sure pinned tabs are restored correctly on start.
 IN_PROC_BROWSER_TEST_F(BrowserTest, RestorePinnedTabs) {
   ASSERT_TRUE(embedded_test_server()->Start());
 
   // Add a pinned tab.
   host_resolver()->AddRule("www.example.com", "127.0.0.1");
   GURL url(embedded_test_server()->GetURL("/empty.html"));
@@ skipping 1405 matching lines @@
     Browser* browser = new Browser(params);
     gfx::Rect bounds = browser->window()->GetBounds();
 
     // Should be EXPECT_EQ, but this width is inconsistent across platforms.
     // See https://crbug.com/567925.
     EXPECT_GE(bounds.width(), 100);
     EXPECT_EQ(122, bounds.height());
     browser->window()->Close();
   }
 }