Issue 275783002: Fix an ExtensionPopup crash on browser window close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275783002: Fix an ExtensionPopup crash on browser window close. (Closed)

Created:
6 years, 7 months ago by msw

Modified:
6 years, 7 months ago

Reviewers:
Finnur, sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, kkania, jam, jyasskin (not chrome)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix an ExtensionPopup crash on browser window close. Check for NULL |activation_client| in ExtensionPopup::OnWidgetDestroying. Add a BrowserActionInteractiveTest that crashes without this fix. Add a BrowserActionTestUtil::InspectPopup helper on Views. BUG=327776 TEST=Inspecting an extension popup bubble and closing the underlying browser window does not crash. R=sky@chromium.org,finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269600

Patch Set 1 #

Patch Set 2 : Fix build. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -7 lines)			Patch
M	chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

msw

Hey Scott and Finnur, please review views and extensions respectively; thanks!

6 years, 7 months ago (2014-05-09 07:07:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/275783002/20001

6 years, 7 months ago (2014-05-09 16:10:52 UTC) #5

Message was sent while issue was closed.

Change committed as 269600

Expand Messages | Collapse Messages