Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2757813002: don't produce errors from inference for downward inferred type variables (Closed)

Created:
3 years, 9 months ago by Jennifer Messerly
Modified:
3 years, 9 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

don't produce errors from inference for downward inferred type variables R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/f51ad4cef7439b5423ce71a95284355e39d2ac59

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -101 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 34 chunks +111 lines, -93 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Leaf
lgtm
3 years, 9 months ago (2017-03-17 11:33:16 UTC) #2
Jennifer Messerly
3 years, 9 months ago (2017-03-18 00:06:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f51ad4cef7439b5423ce71a95284355e39d2ac59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698