Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: runtime/vm/dwarf.cc

Issue 2757783003: Set TARGET_OS_* from GN, falling back to HOST_OS_*. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dwarf.cc
diff --git a/runtime/vm/dwarf.cc b/runtime/vm/dwarf.cc
index 508bb9de13f20ba1bce97ae006ebee0677272ef6..fc5a87c10386f9c48022907469277d3ca80baf7b 100644
--- a/runtime/vm/dwarf.cc
+++ b/runtime/vm/dwarf.cc
@@ -154,10 +154,12 @@ void Dwarf::WriteAbbreviations() {
// DIEs. Each DIE begins with an abbreviation code, and the abbreviation
// describes the attributes of that DIE and their representation.
-#if defined(HOST_OS_MACOS)
+#if defined(TARGET_OS_MACOS) || TARGET_OS_IOS
Print(".section __DWARF,__debug_abbrev,regular,debug\n");
-#else
+#elif defined(TARGET_OS_LINUX) || defined(TARGET_OS_ANDROID)
Print(".section .debug_abbrev,\"\"\n");
+#else
+ UNIMPLEMENTED();
#endif
uleb128(kCompilationUnit); // Abbrev code.
@@ -227,10 +229,12 @@ void Dwarf::WriteAbbreviations() {
void Dwarf::WriteCompilationUnit() {
// 7.5.1.1 Compilation Unit Header
-#if defined(HOST_OS_MACOS)
+#if defined(TARGET_OS_MACOS) || TARGET_OS_IOS
Print(".section __DWARF,__debug_info,regular,debug\n");
-#else
+#elif defined(TARGET_OS_LINUX) || defined(TARGET_OS_ANDROID)
Print(".section .debug_info,\"\"\n");
+#else
+ UNIMPLEMENTED();
#endif
Print(".Ldebug_info:\n");
@@ -455,10 +459,12 @@ void Dwarf::WriteInliningNode(InliningNode* node,
void Dwarf::WriteLines() {
-#if defined(HOST_OS_MACOS)
+#if defined(TARGET_OS_MACOS) || TARGET_OS_IOS
Print(".section __DWARF,__debug_line,regular,debug\n");
-#else
+#elif defined(TARGET_OS_LINUX) || defined(TARGET_OS_ANDROID)
Print(".section .debug_line,\"\"\n");
+#else
+ UNIMPLEMENTED();
#endif
// 6.2.4 The Line Number Program Header

Powered by Google App Engine
This is Rietveld 408576698