Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/dart.cc

Issue 2757783003: Set TARGET_OS_* from GN, falling back to HOST_OS_*. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/platform/globals.h ('K') | « runtime/vm/cpu_arm.cc ('k') | runtime/vm/disassembler_arm.cc » ('j') | runtime/vm/snapshot.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index f7869171196896334e710f65e16894347c60a308..4a2a5fb3a5fbd98af14ef7588d8ea8d8f4799d26 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -679,12 +679,10 @@ const char* Dart::FeaturesString(Isolate* isolate, Snapshot::Kind kind) {
// Generated code must match the host architecture and ABI.
#if defined(TARGET_ARCH_ARM)
-#if defined(TARGET_ABI_IOS)
+#if defined(TARGET_OS_MACOS) || TARGET_OS_IOS
buffer.AddString(" arm-ios");
-#elif defined(TARGET_ABI_EABI)
- buffer.AddString(" arm-eabi");
#else
-#error Unknown ABI
+ buffer.AddString(" arm-eabi");
#endif
buffer.AddString(TargetCPUFeatures::hardfp_supported() ? " hardfp"
: " softfp");
« runtime/platform/globals.h ('K') | « runtime/vm/cpu_arm.cc ('k') | runtime/vm/disassembler_arm.cc » ('j') | runtime/vm/snapshot.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698