runtime/vm/dart.cc - Issue 2757783003: Set TARGET_OS_* from GN, falling back to HOST_OS_*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 2757783003: Set TARGET_OS_* from GN, falling back to HOST_OS_*. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index f7869171196896334e710f65e16894347c60a308..14b7cf170d6b0b83270e94890723991f8167d5b0 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -679,12 +679,10 @@ const char* Dart::FeaturesString(Isolate* isolate, Snapshot::Kind kind) {

// Generated code must match the host architecture and ABI.

#if defined(TARGET_ARCH_ARM)

-#if defined(TARGET_ABI_IOS)

+#if defined(TARGET_OS_MACOS) || defined(TARGET_OS_MACOS_IOS)

buffer.AddString(" arm-ios");

-#elif defined(TARGET_ABI_EABI)

- buffer.AddString(" arm-eabi");

#else

-#error Unknown ABI

+ buffer.AddString(" arm-eabi");

#endif

buffer.AddString(TargetCPUFeatures::hardfp_supported() ? " hardfp"

: " softfp");

« no previous file with comments | « runtime/vm/cpu_arm.cc ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »