Set TARGET_OS_* from GN, falling back to HOST_OS_*.

Set TARGET_OS_* from GN, falling back to HOST_OS_*.

Use TARGET_OS_* instead of HOST_OS_* to decide on the assembly variant to use. Allows, say, a gen_snapshot compiled for a Mac to target Android when generating AOT as assembly.

R=fschneider@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9f2668c9987f0a86cac9cd46c5e3418df22e9f38

[rmacnak, 2017-03-17 01:16:48]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, zra@google.com

[zra, 2017-03-17 17:24:24]

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/globals.h
File runtime/platform/globals.h (right):

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/global...
runtime/platform/globals.h:384: #if !defined(TARGET_OS_ANDROID)
Why not:
#if !defined(...) && \
     !defined(...) && \
     ...

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/global...
runtime/platform/globals.h:399: // XCode >= 7.0. See Issue #24453.
Can we use a different symbol? Maybe TARGET_OS_MACOS_IOS? TARGET_OS_IPHONE_OS?

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:899: #if defined(TARGET_OS_LINUX) ||
defined(TARGET_OS_ANDROID)
Would it make sense to speculatively include FUCHSIA here as well?

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:901: #elif defined(TARGET_OS_MACOS) ||
defined(TARGET_OS_IOS)
no define() around TARGET_OS_IOS, right?. (Maybe choose a different symbol?)

[rmacnak, 2017-03-17 18:22:16]

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/globals.h
File runtime/platform/globals.h (right):

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/global...
runtime/platform/globals.h:384: #if !defined(TARGET_OS_ANDROID)
On 2017/03/17 17:24:24, zra wrote:
> Why not:
> #if !defined(...) && \
>      !defined(...) && \
>      ...

Copied idiom from the equivalent section for TARGET_ARCH. Updated both to &&.

https://codereview.chromium.org/2757783003/diff/80001/runtime/platform/global...
runtime/platform/globals.h:399: // XCode >= 7.0. See Issue #24453.
On 2017/03/17 17:24:24, zra wrote:
> Can we use a different symbol? Maybe TARGET_OS_MACOS_IOS? TARGET_OS_IPHONE_OS?

Sure. TARGET_OS_MACOS_IOS seems like a good choice because it reflects our
treatment of iOS as a subtype of Mac in the platform-specific files.

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:899: #if defined(TARGET_OS_LINUX) ||
defined(TARGET_OS_ANDROID)
On 2017/03/17 17:24:24, zra wrote:
> Would it make sense to speculatively include FUCHSIA here as well?

Did a quick check and they are using the Linux variant.

[zra, 2017-03-17 19:39:16]

lgtm and thanks for the cleanups

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/2757783003/diff/80001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:899: #if defined(TARGET_OS_LINUX) ||
defined(TARGET_OS_ANDROID)
On 2017/03/17 18:22:16, rmacnak wrote:
> On 2017/03/17 17:24:24, zra wrote:
> > Would it make sense to speculatively include FUCHSIA here as well?
> 
> Did a quick check and they are using the Linux variant.

Cool, thanks!

[Florian Schneider, 2017-03-17 20:24:37]

lgtm

[rmacnak, 2017-03-20 21:48:33]

Description was changed from

==========
Set TARGET_OS_* from GN, falling back to HOST_OS_*.

Use TARGET_OS_* instead of HOST_OS_* to decide on the assembly variant to use.
Allows, say, a gen_snapshot compiled for a Mac to target Android when generating
AOT as assembly.
==========

to

==========
Set TARGET_OS_* from GN, falling back to HOST_OS_*.

Use TARGET_OS_* instead of HOST_OS_* to decide on the assembly variant to use.
Allows, say, a gen_snapshot compiled for a Mac to target Android when generating
AOT as assembly.

R=fschneider@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9f2668c9987f0a86cac9cd46c5e3418df22e9f38
==========

[rmacnak, 2017-03-20 21:48:34]

Committed patchset #7 (id:120001) manually as
9f2668c9987f0a86cac9cd46c5e3418df22e9f38 (presubmit successful).