Support providers with two namespaces

components/offline_items_collection/core/offline_item.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_items_collection/core/offline_item.h"
 
 namespace offline_items_collection {
 
 ContentId::ContentId() = default;
 
@@ skipping 43 matching lines @@
          page_url == offline_item.page_url &&
          original_url == offline_item.original_url &&
          is_off_the_record == offline_item.is_off_the_record &&
          state == offline_item.state &&
          is_resumable == offline_item.is_resumable &&
          received_bytes == offline_item.received_bytes &&
          percent_completed == offline_item.percent_completed &&
          time_remaining_ms == offline_item.time_remaining_ms;
 }
 
+bool OfflineItem::operator<(const OfflineItem& offline_item) const {
+  return id < offline_item.id;

[fgorski, 2017/03/17 04:15:16]

this is a little dangerous as (!(a < b) && !(b < a)) should imply equality,
which will be inconsistent with implementation of operator== . At least
documenting that would be useful.

[David Trainor- moved to gerrit, 2017/03/22 00:12:45]

Yeah that's a good point.  I didn't like this either.  I only needed it for a
unit test so I just wrote a custom comparator there for std::map.

+}
+
 }  // namespace offline_items_collection