Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Issue 2757643002: components/image_fetcher: Expose RequestMetadata from ImageFetcher (Closed)
Patch Set: logo_bridge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
index 267c9b9fea9a41cad89fc04eb9d58d34f97c89a5..b803c862ab806e08720915ccbaa94cad148cf074 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
@@ -26,6 +26,7 @@
#include "components/image_fetcher/image_decoder.h"
#include "components/image_fetcher/image_fetcher.h"
#include "components/image_fetcher/image_fetcher_delegate.h"
+#include "components/image_fetcher/request_metadata.h"
#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/category_info.h"
#include "components/ntp_snippets/category_rankers/category_ranker.h"
@@ -287,14 +288,19 @@ std::string GetIncompleteSuggestion() {
using ServeImageCallback = base::Callback<void(
const std::string&,
- base::Callback<void(const std::string&, const gfx::Image&)>)>;
+ base::Callback<void(const std::string&,
+ const gfx::Image&,
+ const image_fetcher::RequestMetadata&)>)>;
void ServeOneByOneImage(
image_fetcher::ImageFetcherDelegate* notify,
const std::string& id,
- base::Callback<void(const std::string&, const gfx::Image&)> callback) {
+ base::Callback<void(const std::string&,
+ const gfx::Image&,
+ const image_fetcher::RequestMetadata&)> callback) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(callback, id, gfx::test::CreateImage(1, 1)));
+ FROM_HERE, base::Bind(callback, id, gfx::test::CreateImage(1, 1),
+ image_fetcher::RequestMetadata()));
notify->OnImageDataFetched(id, "1-by-1-image-data");
}
@@ -345,11 +351,10 @@ class MockImageFetcher : public ImageFetcher {
MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*));
MOCK_METHOD1(SetDataUseServiceName, void(DataUseServiceName));
MOCK_METHOD1(SetDesiredImageFrameSize, void(const gfx::Size&));
- MOCK_METHOD3(
- StartOrQueueNetworkRequest,
- void(const std::string&,
- const GURL&,
- base::Callback<void(const std::string&, const gfx::Image&)>));
+ MOCK_METHOD3(StartOrQueueNetworkRequest,
+ void(const std::string&,
+ const GURL&,
+ const ImageFetcherCallback&));
MOCK_METHOD0(GetImageDecoder, image_fetcher::ImageDecoder*());
};
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_provider_impl.cc ('k') | components/ntp_tiles/icon_cacher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698