Initial support for accessible text fields and focus tracking in ARC++

chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h"
 
 #include <string>
 
 #include "chrome/browser/extensions/api/automation_internal/automation_event_router.h"
 #include "chrome/browser/ui/aura/accessibility/automation_manager_aura.h"
@@ skipping 65 matching lines @@
   if (!node->booleanProperties)
     return false;
 
   auto it = node->booleanProperties->find(prop);
   if (it == node->booleanProperties->end())
     return false;
 
   return it->second;
 }
 
+bool GetIntProperty(arc::mojom::AccessibilityNodeInfoData* node,
+                       arc::mojom::AccessibilityIntProperty prop,

[dmazzoni, 2017/03/17 03:22:37]

nit: indentation

[David Tseng, 2017/03/17 15:38:32]

Done.

+                       int32_t* out_value) {
+  if (!node->intProperties)
+    return false;
+
+  auto it = node->intProperties->find(prop);
+  if (it == node->intProperties->end())
+    return false;
+
+  *out_value = it->second;
+  return true;
+}
+
 bool GetStringProperty(arc::mojom::AccessibilityNodeInfoData* node,
                        arc::mojom::AccessibilityStringProperty prop,
                        std::string* out_value) {
   if (!node->stringProperties)
     return false;
 
   auto it = node->stringProperties->find(prop);
   if (it == node->stringProperties->end())
     return false;
 
@@ skipping 203 matching lines @@
 mojom::AccessibilityNodeInfoData* AXTreeSourceArc::GetNull() const {
   return nullptr;
 }
 
 void AXTreeSourceArc::SerializeNode(mojom::AccessibilityNodeInfoData* node,
                                     ui::AXNodeData* out_data) const {
   if (!node)
     return;
   out_data->id = node->id;
 
+  using AXIntProperty = arc::mojom::AccessibilityIntProperty;
   using AXStringProperty = arc::mojom::AccessibilityStringProperty;
   std::string text;
   if (GetStringProperty(node, AXStringProperty::TEXT, &text))
     out_data->SetName(text);
   else if (GetStringProperty(node, AXStringProperty::CONTENT_DESCRIPTION,
                              &text))
     out_data->SetName(text);
 
   int32_t id = node->id;
   if (id == root_id_)
     out_data->role = ui::AX_ROLE_ROOT_WEB_AREA;
   else
     PopulateAXRole(node, out_data);
 
   PopulateAXState(node, out_data);
 
   const gfx::Rect bounds_in_screen = GetBounds(node);
   out_data->location.SetRect(bounds_in_screen.x(), bounds_in_screen.y(),
                              bounds_in_screen.width(),
                              bounds_in_screen.height());
 
   if (out_data->role == ui::AX_ROLE_TEXT_FIELD && !text.empty())
     out_data->AddStringAttribute(ui::AX_ATTR_VALUE, text);
+
+  // Integer properties.
+  int32_t val;
+  if (GetIntProperty(node, AXIntProperty::TEXT_SELECTION_START,

[yawano, 2017/03/17 08:38:23]

Node can have both TEXT_SELECTION_START and TEXT_SELECTION_END. It would be

if (TEXT_SELECTION_START) {
  // Set start value
}

if (TEXT_SELECTION_END) {
  // Set end value
}

Not like,

if (A) {} else if (B) {}

[David Tseng, 2017/03/17 15:38:32]

Done.

+                     &val) && val >= 0) {
+    out_data->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, val);
+    out_data->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, val);

[yawano, 2017/03/17 08:38:23]

This line of setting AX_ATTR_TEXT_SEL_END would be unnecessary.

[David Tseng, 2017/03/17 15:38:32]

Yeah totally; was wip while I was trying to figure out why the text field gets
detached from its parent.

+  } else if (GetIntProperty(node, AXIntProperty::TEXT_SELECTION_END,
+                            &val) && val >= 0) {
+    out_data->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, val);
+  }
 }
 
 void AXTreeSourceArc::Reset() {
   tree_map_.clear();
   parent_map_.clear();
   current_tree_serializer_.reset(new AXTreeArcSerializer(this));
   root_id_ = -1;
   focused_node_id_ = -1;
   extensions::AutomationEventRouter* router =
       extensions::AutomationEventRouter::GetInstance();
   router->DispatchTreeDestroyedEvent(tree_id_, nullptr);
 }
 
 }  // namespace arc