Issue 2757603005: use js_ast to more efficiently turn the JSON into a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2757603005: use js_ast to more efficiently turn the JSON into a string. (Closed)

Created:
3 years, 9 months ago by Jacob

Modified:
3 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

use js_ast to more efficiently turn the JSON into a string. js_ast will notice the string only contains double quotes so will enclose it with single quotes. Parsing a string appears to be a bit more efficient than parsing JSON. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/00dd9f26a62d9965f15a326f9b86cb57a9759219

Created: 3 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/compiler.dart	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Jacob

3 years, 9 months ago (2017-03-17 15:17:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:10001) manually as
00dd9f26a62d9965f15a326f9b86cb57a9759219 (presubmit successful).