Add window open and close delegate methods to CWVUIDelegate.

ios/web_view/internal/cwv_web_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web_view/public/cwv_web_view.h"
 
 #include <memory>
 #include <utility>
 
 #import "base/ios/weak_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/sys_string_conversions.h"
 #import "ios/web/public/navigation_manager.h"
 #include "ios/web/public/referrer.h"
 #include "ios/web/public/reload_type.h"
 #import "ios/web/public/web_state/context_menu_params.h"
 #import "ios/web/public/web_state/js/crw_js_injection_receiver.h"
 #import "ios/web/public/web_state/ui/crw_web_delegate.h"
 #import "ios/web/public/web_state/web_state.h"
 #import "ios/web/public/web_state/web_state_delegate_bridge.h"
 #import "ios/web/public/web_state/web_state_observer_bridge.h"
 #import "ios/web_view/internal/cwv_html_element_internal.h"
+#import "ios/web_view/internal/cwv_navigation_action_internal.h"
 #import "ios/web_view/internal/cwv_website_data_store_internal.h"
 #import "ios/web_view/internal/translate/web_view_translate_client.h"
 #include "ios/web_view/internal/web_view_browser_state.h"
 #import "ios/web_view/internal/web_view_java_script_dialog_presenter.h"
 #import "ios/web_view/internal/web_view_web_state_policy_decider.h"
 #import "ios/web_view/public/cwv_navigation_delegate.h"
 #import "ios/web_view/public/cwv_ui_delegate.h"
 #import "ios/web_view/public/cwv_web_view_configuration.h"
 #import "ios/web_view/public/cwv_website_data_store.h"
 #import "net/base/mac/url_conversions.h"
@@ skipping 10 matching lines @@
   double _estimatedProgress;
   // Handles presentation of JavaScript dialogs.
   std::unique_ptr<ios_web_view::WebViewJavaScriptDialogPresenter>
       _javaScriptDialogPresenter;
 }
 
 // Redefine the property as readwrite to define -setEstimatedProgress:, which
 // can be used to send KVO notification.
 @property(nonatomic, readwrite) double estimatedProgress;
 
+//@property(nonatomic, readonly) web::WebState estimatedProgress;

[Eugene But (OOO till 7-30), 2017/03/16 17:09:02]

Please remove this

[michaeldo, 2017/03/16 18:24:28]

Done.

+
 @end
 
 @implementation CWVWebView
 
 @synthesize navigationDelegate = _navigationDelegate;
 @synthesize translationDelegate = _translationDelegate;
 @synthesize estimatedProgress = _estimatedProgress;
 @synthesize UIDelegate = _UIDelegate;
 
 - (instancetype)initWithFrame:(CGRect)frame
@@ skipping 158 matching lines @@
                                     mediaSource:mediaSource
                                            text:params.link_text];
   [_UIDelegate webView:self
       runContextMenuWithTitle:params.menu_title
                forHTMLElement:HTMLElement
                        inView:params.view
           userGestureLocation:params.location];
   return YES;
 }
 
+- (web::WebState*)webState:(web::WebState*)webState
+    createNewWebStateForURL:(const GURL&)URL
+                  openerURL:(const GURL&)openerURL
+            initiatedByUser:(BOOL)initiatedByUser {
+  SEL selector =
+      @selector(webView:createWebViewWithConfiguration:forNavigationAction:);
+  if (![_UIDelegate respondsToSelector:selector]) {
+    return nil;
+  }
+
+  NSURLRequest* request =
+      [[NSURLRequest alloc] initWithURL:net::NSURLWithGURL(URL)];
+  CWVNavigationAction* navigationAction =
+      [[CWVNavigationAction alloc] initWithRequest:request
+                                     userInitiated:initiatedByUser];
+  CWVWebView* webView = [_UIDelegate webView:self
+              createWebViewWithConfiguration:_configuration
+                         forNavigationAction:navigationAction];

[Eugene But (OOO till 7-30), 2017/03/16 17:09:02]

This will create a non-closable window. WebState can only be closed if it was
open by DOM. Calling NavigationManagerImpl::InitializeSession(YES) would solve
your problem, but Kurt is removing opened_by_dom flag:
https://codereview.chromium.org/2755823002/

I think it's ok to land your CL with TODO and fix this problem separately after
cl/2755823002 lands.

[michaeldo, 2017/03/16 18:24:28]

Thank you for the details, I have created a bug and will followup once that CL
lands.

+  return webView->_webState.get();

[Eugene But (OOO till 7-30), 2017/03/16 17:09:02]

This will crash if |webView| is nil.

[michaeldo, 2017/03/16 18:24:28]

I've added a check that a webview was in fact returned.

+}
+
+- (void)closeWebState:(web::WebState*)webState {
+  SEL selector = @selector(webViewDidClose:);
+  if (![_UIDelegate respondsToSelector:selector]) {

[Eugene But (OOO till 7-30), 2017/03/16 17:09:02]

nit: How about this?:

if ([_UIDelegate respondsToSelector:@selector(webViewDidClose:)]) {
  [_UIDelegate webViewDidClose:self];
}

[michaeldo, 2017/03/16 18:24:28]

Done.

+    return;
+  }
+  [_UIDelegate webViewDidClose:self];
+}
+
 - (web::JavaScriptDialogPresenter*)javaScriptDialogPresenterForWebState:
     (web::WebState*)webState {
   return _javaScriptDialogPresenter.get();
 }
 
 @end