ios/web_view/internal/cwv_navigation_action_internal.h - Issue 2757603003: Add window open and close delegate methods to CWVUIDelegate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/internal/cwv_navigation_action_internal.h

Issue 2757603003: Add window open and close delegate methods to CWVUIDelegate. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_INTERNAL_CWV_NAVIGATION_ACTION_INTERNAL_H_

	6 #define IOS_WEB_VIEW_INTERNAL_CWV_NAVIGATION_ACTION_INTERNAL_H_

	7

	8 #import "ios/web_view/public/cwv_navigation_action.h"

	9

	10 @interface CWVNavigationAction ()

	11

	12 - (nonnull instancetype)init NS_UNAVAILABLE;

	13

	14 - (nonnull instancetype)initWithRequest:(nonnull NSURLRequest*)hyperlink
	Eugene But (OOO till 7-30) 2017/03/16 17:09:02 s/hyperlink/request This request may be initiated s/hyperlink/request This request may be initiated by window.open, which is not a hyperlink. michaeldo 2017/03/16 18:24:28 Sorry, must've been a copy/paste error. Fixed. Show quoted text On 2017/03/16 17:09:02, Eugene But wrote: > s/hyperlink/request > > This request may be initiated by window.open, which is not a hyperlink. Sorry, must've been a copy/paste error. Fixed.
	15 userInitiated:(BOOL)userInitiated

	16 NS_DESIGNATED_INITIALIZER;

	17

	18 @end

	19

	20 #endif // IOS_WEB_VIEW_INTERNAL_CWV_NAVIGATION_ACTION_INTERNAL_H_

OLD	NEW