Work around Platform.ansiSupported missing from checked-in dart binary.

Work around Platform.ansiSupported missing from checked-in dart binary.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/21c7e6dd6b280f0ad47762e7d27c8518e2c862a4

[ahe, 2017-03-16 12:58:31]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-16 12:58:51]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-16 13:01:47]

LGTM

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/colors.dart (right):

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:101: bool ansiSupported;
Initialize with 'false'?

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:104: } catch (e) {
Could you be more specific about the exception type that you expect when this
getter is not available?

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:105: // Ignored.
Maybe add something like: 'the getter is not supported in this version of the
VM'.

[ahe, 2017-03-16 13:11:10]

Thank you, Karl!

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/colors.dart (right):

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:101: bool ansiSupported;
On 2017/03/16 13:01:47, karlklose wrote:
> Initialize with 'false'?

I have to distinguish between three cases:

* We know that ansi mode isn't supported.

* We know that ansi mode is supported.

* We don't know if ansi mode is supported.

Null represents the latter, and this is used to avoid returning in the case on
line 107.

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:104: } catch (e) {
On 2017/03/16 13:01:47, karlklose wrote:
> Could you be more specific about the exception type that you expect when this
> getter is not available?

Done.

https://codereview.chromium.org/2757593003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:105: // Ignored.
On 2017/03/16 13:01:46, karlklose wrote:
> Maybe add something like: 'the getter is not supported in this version of the
> VM'.

Done.

[ahe, 2017-03-16 13:14:13]

Description was changed from

==========
Work around Platform.ansiSupported missing from checked-in dart binary.
==========

to

==========
Work around Platform.ansiSupported missing from checked-in dart binary.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/21c7e6dd6b280f0ad47762e7d27c8518e2c862a4
==========

[ahe, 2017-03-16 13:14:14]

Committed patchset #2 (id:40001) manually as
21c7e6dd6b280f0ad47762e7d27c8518e2c862a4 (presubmit successful).