Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8744)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2757563002: Revert of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
index 1a00ca78e900b4506f2ca7de173ee519b36bf070..6dbc0ea05535a10ec5bd6291ce0b0ec1e8e36ada 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
@@ -120,10 +120,13 @@
return;
}
- Callback<Integer> callback = new Callback<Integer>() {
- @Override
- public void onResult(Integer result) {
- WebApkInstaller.this.notify(result);
+ Callback<Boolean> callback = new Callback<Boolean>() {
+ @Override
+ public void onResult(Boolean success) {
+ // TODO(pkotwicz): Send WebApkInstallResult.PROBABLE_FAILURE result if
+ // install timed out.
+ WebApkInstaller.this.notify(
+ success ? WebApkInstallResult.SUCCESS : WebApkInstallResult.FAILURE);
}
};
mGooglePlayWebApkInstallDelegate.installAsync(
@@ -177,10 +180,13 @@
return;
}
- Callback<Integer> callback = new Callback<Integer>() {
- @Override
- public void onResult(Integer result) {
- WebApkInstaller.this.notify(result);
+ Callback<Boolean> callback = new Callback<Boolean>() {
+ @Override
+ public void onResult(Boolean success) {
+ // TODO(pkotwicz): Send WebApkInstallResult.PROBABLE_FAILURE result if
+ // update timed out.
+ WebApkInstaller.this.notify(
+ success ? WebApkInstallResult.SUCCESS : WebApkInstallResult.FAILURE);
}
};
mGooglePlayWebApkInstallDelegate.installAsync(
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698