Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5697)

Unified Diff: chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc

Issue 2757523002: [Payments] Use PaymentInstrument/AutofillPaymentInstrument throughout. (Closed)
Patch Set: Initial Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
index 4cd3feb30c2325e5db9eae1be2f163104cd586d1..e61440905a5746d00c13cadf70df9054b0d35a94 100644
--- a/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
+++ b/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
@@ -40,14 +40,15 @@ IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, OneCardSelected) {
OpenPaymentMethodScreen();
PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
- EXPECT_EQ(1U, request->state()->credit_cards().size());
+ EXPECT_EQ(1U, request->state()->available_instruments().size());
views::View* list_view = dialog_view()->GetViewByID(
static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
EXPECT_TRUE(list_view);
EXPECT_EQ(1, list_view->child_count());
- EXPECT_EQ(card, *request->state()->selected_credit_card());
+ EXPECT_EQ(request->state()->available_instruments()[0],
+ request->state()->selected_instrument());
views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
static_cast<int>(DialogViewID::CHECKMARK_VIEW));
EXPECT_TRUE(checkmark_view->visible());
@@ -68,15 +69,17 @@ IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest,
OpenPaymentMethodScreen();
PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
- EXPECT_EQ(2U, request->state()->credit_cards().size());
- EXPECT_EQ(card1, *request->state()->selected_credit_card());
+ EXPECT_EQ(2U, request->state()->available_instruments().size());
+ EXPECT_EQ(request->state()->available_instruments()[0],
+ request->state()->selected_instrument());
views::View* list_view = dialog_view()->GetViewByID(
static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
EXPECT_TRUE(list_view);
EXPECT_EQ(2, list_view->child_count());
- EXPECT_EQ(card1, *request->state()->selected_credit_card());
+ EXPECT_EQ(request->state()->available_instruments()[0],
+ request->state()->selected_instrument());
views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
static_cast<int>(DialogViewID::CHECKMARK_VIEW));
EXPECT_TRUE(checkmark_view->visible());
@@ -88,14 +91,16 @@ IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest,
// Simulate selecting the second card.
ClickOnDialogViewAndWait(list_view->child_at(1));
- EXPECT_EQ(card2, *request->state()->selected_credit_card());
+ EXPECT_EQ(request->state()->available_instruments()[1],
+ request->state()->selected_instrument());
EXPECT_FALSE(checkmark_view->visible());
EXPECT_TRUE(checkmark_view2->visible());
// Clicking on the second card again should not modify any state.
ClickOnDialogViewAndWait(list_view->child_at(1));
- EXPECT_EQ(card2, *request->state()->selected_credit_card());
+ EXPECT_EQ(request->state()->available_instruments()[1],
+ request->state()->selected_instrument());
EXPECT_FALSE(checkmark_view->visible());
EXPECT_TRUE(checkmark_view2->visible());
}

Powered by Google App Engine
This is Rietveld 408576698