Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/ui/views/payments/payment_request_views_util.cc

Issue 2757523002: [Payments] Use PaymentInstrument/AutofillPaymentInstrument throughout. (Closed)
Patch Set: addressed nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_views_util.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_views_util.cc b/chrome/browser/ui/views/payments/payment_request_views_util.cc
index 4e3a9b4472eac73039ff9a20c896fbeeb414ea34..1b8cb042897a763688e326b98a3219fac29703a5 100644
--- a/chrome/browser/ui/views/payments/payment_request_views_util.cc
+++ b/chrome/browser/ui/views/payments/payment_request_views_util.cc
@@ -170,18 +170,16 @@ std::unique_ptr<views::View> CreateSheetHeaderView(
return container;
}
-std::unique_ptr<views::ImageView> CreateCardIconView(
- const std::string& card_type) {
+std::unique_ptr<views::ImageView> CreateInstrumentIconView(
+ int icon_resource_id,
+ const base::string16& tooltip_text) {
std::unique_ptr<views::ImageView> card_icon_view =
base::MakeUnique<views::ImageView>();
card_icon_view->set_can_process_events_within_subtree(false);
- card_icon_view->SetImage(
- ResourceBundle::GetSharedInstance()
- .GetImageNamed(autofill::data_util::GetPaymentRequestData(card_type)
- .icon_resource_id)
- .AsImageSkia());
- card_icon_view->SetTooltipText(
- autofill::CreditCard::TypeForDisplay(card_type));
+ card_icon_view->SetImage(ResourceBundle::GetSharedInstance()
+ .GetImageNamed(icon_resource_id)
+ .AsImageSkia());
+ card_icon_view->SetTooltipText(tooltip_text);
card_icon_view->SetBorder(views::CreateRoundedRectBorder(
1, 3, card_icon_view->GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_UnfocusedBorderColor)));

Powered by Google App Engine
This is Rietveld 408576698