[Payments] Use PaymentInstrument/AutofillPaymentInstrument throughout.

components/payments/core/payment_instrument.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAYMENTS_CORE_PAYMENT_INSTRUMENT_H_
 #define COMPONENTS_PAYMENTS_CORE_PAYMENT_INSTRUMENT_H_
 
 #include <set>
 #include <string>
 
 #include "base/macros.h"
+#include "base/strings/string16.h"
 
 namespace payments {
 
 // Base class which represents a form of payment in Payment Request.
 class PaymentInstrument {
  public:
   class Delegate {
    public:
     virtual ~Delegate() {}
 
     // Should be called with method name (e.g., "visa") and json-serialized
     // stringified details.
     virtual void OnInstrumentDetailsReady(
         const std::string& method_name,
         const std::string& stringified_details) = 0;
 
     virtual void OnInstrumentDetailsError() = 0;
   };
 
-  virtual ~PaymentInstrument() {}
+  virtual ~PaymentInstrument();
 
   // Will call into the |delegate| (can't be null) on success or error.
   virtual void InvokePaymentApp(Delegate* delegate) = 0;
+  virtual bool IsValid() = 0;

[please use gerrit instead, 2017/03/16 14:27:03]

Add a comment.

[Mathieu, 2017/03/16 14:57:04]

Done.

 
   const std::string& method_name() { return method_name_; }

[please use gerrit instead, 2017/03/16 14:27:03]

These methods should be const.

[Mathieu, 2017/03/16 14:57:04]

Done.

+  const base::string16& label() { return label_; }
+  const base::string16& sublabel() { return sublabel_; }
+  int icon_resource_id() { return icon_resource_id_; }
 
  protected:
-  explicit PaymentInstrument(const std::string& method_name)
-      : method_name_(method_name) {}
+  PaymentInstrument(const std::string& method_name,
+                    const base::string16& label,
+                    const base::string16& sublabel,
+                    int icon_resource_id);
 
  private:
   const std::string method_name_;
+  const base::string16 label_;
+  const base::string16 sublabel_;
+  int icon_resource_id_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentInstrument);
 };
 
 }  // namespace payments
 
 #endif  // COMPONENTS_PAYMENTS_CORE_PAYMENT_INSTRUMENT_H_