Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2757503002: Fix for bug when binding non-symbolized members on native classes (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for bug when binding non-symbolized members on native classes BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/b4828c39cf74b1ae2d6b914a6741e6942b750671

Patch Set 1 #

Patch Set 2 : use js_ast to more efficiently turn the JSON into a string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 9 months ago (2017-03-16 01:36:51 UTC) #2
vsm
lgtm
3 years, 9 months ago (2017-03-16 01:39:51 UTC) #3
Jacob
3 years, 9 months ago (2017-03-16 01:56:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4828c39cf74b1ae2d6b914a6741e6942b750671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698